Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvm plugin always add "v" for version prefix although it's not a semantic version #504

Closed
ffd114 opened this issue Dec 11, 2023 · 1 comment · Fixed by #506
Closed

nvm plugin always add "v" for version prefix although it's not a semantic version #504

ffd114 opened this issue Dec 11, 2023 · 1 comment · Fixed by #506

Comments

@ffd114
Copy link

ffd114 commented Dec 11, 2023

According to the nvm's docs we can put not only semantic version but also lts/* and node. In the nvm plugin, it will add prefix "v" from .nvmrc file if the first letter is not "v" which will fail to install if the .nvmrc is not semantic version like lts/hydrogen or node

image
@akinomyoga
Copy link
Contributor

The upstream seems to have been changed.

nvm-sh/nvm#2017
nvm-sh/nvm@ff77ac1

akinomyoga added a commit to akinomyoga/oh-my-bash that referenced this issue Dec 12, 2023
@akinomyoga
lib/nvm: update autoloader to keep up with the upstream
75eea53 
Fixes ohmybash#504
@akinomyoga akinomyoga mentioned this issue Dec 12, 2023
Merged
akinomyoga added a commit to akinomyoga/oh-my-bash that referenced this issue Dec 12, 2023
@akinomyoga
lib/nvm: Update autoloader to keep up with the upstream
3303cd6 
Fixes ohmybash#504
akinomyoga added a commit that referenced this issue Dec 12, 2023
@akinomyoga
lib/nvm: Update autoloader to keep up with the upstream (#506)
d2163a6 
Fixes #504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lib/nvm: update autoloader to keep up with the upstream akinomyoga/oh-my-bash
2 participants
@ffd114 @akinomyoga