Replace custom useQuery util with TanStack useQuery #9360

amjithtitus09 · 2024-12-10T20:15:23Z

Proposed Changes

Fixes #issue_number
Replaced custom useQuery util with tanStack useQuery, along with a wrapper for backward compatibility
Added documentation for tanStack usage as well as wrapper usage

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

coderabbitai · 2024-12-10T20:15:34Z

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

44 files out of 126 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2024-12-10T20:15:42Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`e447123`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/675a836cd4cbbe00082097d8
😎 Deploy Preview	https://deploy-preview-9360--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad

This approach LGTM.

Just something to note, our request function does perform query retries by itself. And in this implementation Tanstack's Query Client has retry configured to 1.

We could modify our request to not perform retries.

care_fe/src/Utils/request/request.ts

Line 53 in b25ecd0

for (let i = 0; i < reattempts + 1; i++) {

src/Utils/request/useTanStackQueryInstead.ts

rithviknishad · 2024-12-11T05:35:34Z

Since we have plugins, this approach isn't backwards compatible. We might have to stick with same file and function name useQuery instead of useTanstackQuery instead.

github-actions · 2024-12-11T06:10:16Z

👋 Hi, @amjithtitus09,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

rithviknishad · 2024-12-11T06:54:43Z

Looks like there's an issue with refetching when component remounts.

Example: when we go to asset list page, and open an asset and go back to asset list page using the back button, it shows no assets found.

…th existing ones

…mports in new usages

…oute to ensure behaviour remains same as of previous impleemntation of useQuery

rithviknishad · 2024-12-11T12:10:24Z

Opted out of caching between usages of the useQuery that has the same query key. This was causing so many weird state management issues with our existing implementation.

Cache for the same useQuery invocations is still present as per defaults.

bodhish · 2024-12-12T00:14:30Z

@coderabbitai full review

coderabbitai · 2024-12-12T00:24:31Z

✅ Actions performed

Full review triggered.

Jacobjeevan

Since we merged Users redesign FE yesterday, there's a few more instances of useQuery that ought to be replaced.

Other than that, LGTM.

rithviknishad · 2024-12-12T06:32:52Z

Since we merged Users redesign FE yesterday, there's a few more instances of useQuery that ought to be replaced.

Done, thanks for finding that miss!

github-actions · 2024-12-12T07:15:26Z

@rithviknishad @amjithtitus09 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Replace useQuery util with tanStack

7d3afd7

amjithtitus09 requested a review from a team as a code owner December 10, 2024 20:15

rithviknishad approved these changes Dec 11, 2024

View reviewed changes

rithviknishad added the Major Code Change This Tag represent PR, which will be causing major Code change in the platform label Dec 11, 2024

rithviknishad requested changes Dec 11, 2024

View reviewed changes

src/Utils/request/useTanStackQueryInstead.ts Outdated Show resolved Hide resolved

rithviknishad reviewed Dec 11, 2024

View reviewed changes

src/Utils/request/useTanStackQueryInstead.ts Outdated Show resolved Hide resolved

fixes refetch flow and respect signal from abort controller

b0d4373

rithviknishad mentioned this pull request Dec 11, 2024

Integrate with Tanstack Query #9350

Closed

rename file for backwards compatability

c435014

github-actions bot added the merge conflict pull requests with merge conflict label Dec 11, 2024

Merge remote-tracking branch 'origin' into amjithtitus09/develop

5d588d9

rithviknishad removed the merge conflict pull requests with merge conflict label Dec 11, 2024

amjithtitus09 and others added 2 commits December 11, 2024 12:16

Removed reattempts from request, modified tanStack reattempts to 3

bf3dd76

prettier on request.ts

d14da49

rithviknishad and others added 11 commits December 11, 2024 12:30

fix loading state for existing usages and ensure cache is not used wi…

3013e7b

…th existing ones

Merge branch 'develop' into develop

aacb2d4

fix dependency issue with overrides

af28727

Merge remote-tracking branch 'origin' into amjithtitus09/develop

7174f39

rename useMutation to useDeprecatedMutation to avoid accidental i…

2cda313

…mports in new usages

prevent refetch on window focus

130648f

add react query dev tools

a89e9d8

fix user profile query infinite loop

21255ae

fix cache not getting garbage collected

2c82db3

use only gcTime

42182d7

always refetch on mount

8c9a237

opt-out of tanstack query's caching between usages of hooks of same r…

27c5c80

…oute to ensure behaviour remains same as of previous impleemntation of useQuery

rithviknishad approved these changes Dec 11, 2024

View reviewed changes

rithviknishad assigned rithviknishad and amjithtitus09 Dec 11, 2024

rithviknishad requested review from gigincg, bodhish and a team December 11, 2024 12:16

rithviknishad added the Done label Dec 11, 2024

rithviknishad requested review from shivankacker, khavinshankar, Jacobjeevan and sainak and removed request for a team December 12, 2024 05:08

Jacobjeevan approved these changes Dec 12, 2024

View reviewed changes

shivankacker approved these changes Dec 12, 2024

View reviewed changes

rithviknishad added 2 commits December 12, 2024 12:01

rename recently added usages

7d048ee

Merge remote-tracking branch 'origin' into amjithtitus09/develop

e447123

rithviknishad merged commit 1fb976b into ohcnetwork:develop Dec 12, 2024
19 checks passed

This was referenced Dec 12, 2024

Resolve infinite scroll issue in Resource page #9267

Closed

Integrates useInfiniteQuery for data fetching and resolves Infinite Load issue in Notes. #9190

Merged

amjithtitus09 mentioned this pull request Dec 12, 2024

Util function for cleaner usage of TanStack useQuery #9395

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace custom useQuery util with TanStack useQuery #9360

Replace custom useQuery util with TanStack useQuery #9360

amjithtitus09 commented Dec 10, 2024

coderabbitai bot commented Dec 10, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Dec 10, 2024 •

edited

Loading

rithviknishad left a comment

rithviknishad commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024

rithviknishad commented Dec 11, 2024

rithviknishad commented Dec 11, 2024

bodhish commented Dec 12, 2024

coderabbitai bot commented Dec 12, 2024

Jacobjeevan left a comment

rithviknishad commented Dec 12, 2024

github-actions bot commented Dec 12, 2024

Replace custom useQuery util with TanStack useQuery #9360

Replace custom useQuery util with TanStack useQuery #9360

Conversation

amjithtitus09 commented Dec 10, 2024

Proposed Changes

Merge Checklist

coderabbitai bot commented Dec 10, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Dec 10, 2024 • edited Loading

✅ Deploy Preview for care-ohc ready!

rithviknishad left a comment

Choose a reason for hiding this comment

rithviknishad commented Dec 11, 2024 • edited Loading

github-actions bot commented Dec 11, 2024

rithviknishad commented Dec 11, 2024

rithviknishad commented Dec 11, 2024

bodhish commented Dec 12, 2024

coderabbitai bot commented Dec 12, 2024

Jacobjeevan left a comment

Choose a reason for hiding this comment

rithviknishad commented Dec 12, 2024

github-actions bot commented Dec 12, 2024

coderabbitai bot commented Dec 10, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Dec 10, 2024 •

edited

Loading

rithviknishad commented Dec 11, 2024 •

edited

Loading