Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated crowdin.yml file #9211

Merged
merged 2 commits into from
Nov 28, 2024
Merged

fix: updated crowdin.yml file #9211

merged 2 commits into from
Nov 28, 2024

Conversation

Tanuj1718
Copy link
Contributor

@Tanuj1718 Tanuj1718 commented Nov 26, 2024

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • Chores
    • Updated localization file paths for improved structure and accessibility.

@Tanuj1718 Tanuj1718 requested a review from a team as a code owner November 26, 2024 03:48
Copy link
Contributor

coderabbitai bot commented Nov 26, 2024

Walkthrough

The changes involve updating the crowdin.yml configuration file to modify the paths for localization files. The source path for localization files has been changed from a specific directory structure in the src directory to a more generalized format in the public directory. Similarly, the translation file path has also been updated to reflect this new directory structure.

Changes

File Change Summary
crowdin.yml Updated source path from /src/Locale/en/*.json to /public/locale/{{lang}}.json; updated translation path from /src/Locale/%two_letters_code%/%original_file_name% to /public/locale/%two_letters_code%/%original_file_name%.

Assessment against linked issues

Objective Addressed Explanation
Update the crowdin config to reflect the correct locales path (9018)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 8119ef1
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6746f175547c8e0008ad07dd
😎 Deploy Preview https://deploy-preview-9211--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (1)
crowdin.yml (1)

6-6: Remove unnecessary empty lines

The file contains extra empty lines at the end.

Apply this diff to clean up:

bundles:
  - 2
-

-
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between fdfc53d and 138521a.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • crowdin.yml (1 hunks)

@Tanuj1718
Copy link
Contributor Author

@sainak Can you please check this PR? I have updated crowdin.yml file as instructed in issue #9018

@github-actions github-actions bot added needs-triage question Further information is requested labels Nov 26, 2024
@shivankacker shivankacker added needs testing and removed question Further information is requested needs-triage labels Nov 27, 2024
@shivankacker shivankacker requested a review from sainak November 27, 2024 10:17
@nihal467
Copy link
Member

marking it testing as shivank reviewed it

@bodhish bodhish merged commit 6bea49a into ohcnetwork:develop Nov 28, 2024
20 checks passed
Copy link

@Tanuj1718 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

UdaySagar-Git pushed a commit to UdaySagar-Git/care_fe that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update crowdin config file
4 participants