Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Update Details' Button in Community Nurse Log Update Details Page #9094

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

kihan2518B
Copy link

@kihan2518B kihan2518B commented Nov 12, 2024

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • New Features
    • Added an "Update Log" button in the Critical Care Preview component for easy access to update daily rounds details.
    • Introduced a new primary button variant with enhanced styles for light and dark themes, expanding visual options for users.

@kihan2518B kihan2518B requested a review from a team as a code owner November 12, 2024 10:47
Copy link
Contributor

coderabbitai bot commented Nov 12, 2024

Walkthrough

The changes involve the addition of a new button labeled "Update Log" in the CriticalCarePreview component located in src/components/LogUpdate/CriticalCarePreview.tsx. This button is positioned beneath the existing "Back to Consultation" button and links to a URL for updating daily rounds details using specific props. The integration does not affect existing functionality or logic within the component, maintaining the current data fetching and rendering processes.

Changes

File Path Change Summary
src/components/LogUpdate/CriticalCarePreview.tsx Added "Update Log" button below "Back to Consultation" for updating daily rounds details.
src/components/ui/button.tsx Introduced a new primary button variant with specific styles for light and dark themes.

Assessment against linked issues

Objective Addressed Explanation
Add "Update Details" Button in view details page (#9060) The button is labeled "Update Log" instead of "Update Details".

Possibly related PRs

Suggested labels

needs review, tested

Suggested reviewers

  • rithviknishad
  • Jacobjeevan
  • shivankacker

Poem

In the realm of care, a button appears,
"Update Log" now calms all fears.
Beneath the old, it finds its place,
A path to updates, a smoother grace.
With clicks and taps, our tasks align,
In the world of health, all will be fine! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 18fde17 and 070cc54.

📒 Files selected for processing (1)
  • src/components/LogUpdate/CriticalCarePreview.tsx (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/components/LogUpdate/CriticalCarePreview.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 070cc54
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67484cc254e6be000823851d
😎 Deploy Preview https://deploy-preview-9094--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c0ffd4a and 3b6d2c3.

📒 Files selected for processing (1)
  • src/components/LogUpdate/CriticalCarePreview.tsx (1 hunks)
🔇 Additional comments (2)
src/components/LogUpdate/CriticalCarePreview.tsx (2)

59-69: Button layout integration looks good

The new button is well-integrated into the existing layout with consistent spacing and styling.


62-66: Implementation successfully meets PR objectives

The added button provides the required direct navigation to the edit log update page as specified in issue #9060. The URL construction is correct and includes all necessary parameters.

src/components/LogUpdate/CriticalCarePreview.tsx Outdated Show resolved Hide resolved
@kihan2518B
Copy link
Author

@rithviknishad can you review my pr

@nihal467
Copy link
Member

nihal467 commented Nov 18, 2024

image
image
@kihan2518B

  • As per the existing design of "Brief Update" and the issue description, position the "Update Details" button at the top-right corner of the card for both the "Community Nurse" and "Detail Log Update" view details pages.

@nihal467
Copy link
Member

image

@kihan2518B keep the button colour primary ,

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do replace existing ButtonV2's with shadcn's button too btw. Also previously requested changes are still not resolved.

src/components/LogUpdate/CriticalCarePreview.tsx Outdated Show resolved Hide resolved
@rithviknishad
Copy link
Member

Kindly request for review only once all changes requested are resolved.

@rithviknishad rithviknishad removed their request for review November 27, 2024 16:07
@rithviknishad
Copy link
Member

@coderabbitai review

Copy link
Contributor

coderabbitai bot commented Nov 27, 2024

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@kihan2518B kihan2518B force-pushed the issues/9060/add-update-button-log-details branch from 18fde17 to 070cc54 Compare November 28, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Update Details" Button in view details page of community nurse and details log update
4 participants