-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Update Details' Button in Community Nurse Log Update Details Page #9094
base: develop
Are you sure you want to change the base?
Add 'Update Details' Button in Community Nurse Log Update Details Page #9094
Conversation
WalkthroughThe changes involve the addition of a new button labeled "Update Log" in the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
src/components/LogUpdate/CriticalCarePreview.tsx
(1 hunks)
🔇 Additional comments (2)
src/components/LogUpdate/CriticalCarePreview.tsx (2)
59-69
: Button layout integration looks good
The new button is well-integrated into the existing layout with consistent spacing and styling.
62-66
: Implementation successfully meets PR objectives
The added button provides the required direct navigation to the edit log update page as specified in issue #9060. The URL construction is correct and includes all necessary parameters.
@rithviknishad can you review my pr |
|
@kihan2518B keep the button colour primary , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do replace existing ButtonV2's with shadcn's button too btw. Also previously requested changes are still not resolved.
Kindly request for review only once all changes requested are resolved. |
@coderabbitai review |
✅ Actions performedReview triggered.
|
18fde17
to
070cc54
Compare
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit
primary
button variant with enhanced styles for light and dark themes, expanding visual options for users.