Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored FileUpload component #8329

Merged
merged 12 commits into from
Aug 23, 2024
Merged

Refactored FileUpload component #8329

merged 12 commits into from
Aug 23, 2024

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented Aug 14, 2024 •
edited
Loading

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@vercel Vercel
Copy link

vercel bot commented Aug 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 7:28am

@netlify Netlify
Copy link

netlify bot commented Aug 14, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit db7f198
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c839d1fd4a71000846f66b
😎 Deploy Preview https://deploy-preview-8329--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented Aug 14, 2024 •
edited
Loading

CARE    Run #3174

Run Properties:  status check passed Passed #3174  •  git commit db7f198e23: Refactored FileUpload component
Project CARE
Branch Review fileupload-refactor
Run status status check passed Passed #3174
Run duration 02m 58s
Commit git commit db7f198e23: Refactored FileUpload component
Committer Shivank Kacker
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 126
View all changes introduced in this branch ↗︎

@shivankacker shivankacker marked this pull request as ready for review August 17, 2024 08:11
@shivankacker shivankacker requested a review from a team as a code owner August 17, 2024 08:11
@nihal467
Copy link
Member

image

  • @shivankacker click the view button, once the discharge summary is uploaded to the section , there will be error thrown

@rithviknishad rithviknishad self-requested a review August 20, 2024 18:24
@nihal467
Copy link
Member

LGTM

khavinshankar
khavinshankar requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@khavinshankar khavinshankar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivankacker the refactor looks good, way cleaner compared to the previous version, just i18n the text and let's get it merged. Please check all the changed files, in some places i18n were missing.

src/Components/Files/AudioCaptureDialog.tsx Outdated Show resolved Hide resolved
@shivankacker
Copy link
Member Author

@nihal467 internationalisation done

cc. @gigincg @khavinshankar

khavinshankar
khavinshankar reviewed Aug 22, 2024
View reviewed changes
src/Components/Patient/ManagePatients.tsx Outdated Show resolved Hide resolved
src/Components/Patient/ManagePatients.tsx Outdated Show resolved Hide resolved
src/Components/Patient/PatientConsentRecords.tsx Outdated Show resolved Hide resolved
src/Components/Resource/ResourceBoardView.tsx Outdated Show resolved Hide resolved
src/Utils/useFileUpload.tsx Outdated Show resolved Hide resolved
src/Components/Files/AudioCaptureDialog.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

👋 Hi, @shivankacker,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Aug 22, 2024
@shivankacker shivankacker removed changes required merge conflict pull requests with merge conflict labels Aug 23, 2024
@khavinshankar khavinshankar merged commit 0daadf2 into develop Aug 23, 2024
60 of 62 checks passed
@khavinshankar khavinshankar deleted the fileupload-refactor branch August 23, 2024 07:40
@github-actions GitHub Actions
Copy link

@shivankacker Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

UdaySagar-Git added a commit to UdaySagar-Git/care_fe that referenced this pull request Aug 23, 2024
@UdaySagar-Git
Refactored FileUpload component (ohcnetwork#8329)
5bff760
@rithviknishad rithviknishad mentioned this pull request Sep 5, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate FileUpload page to useFileUpload and useFileManager hooks
4 participants
@shivankacker @nihal467 @rithviknishad @khavinshankar