Fixes for OrganizationUsers.tsx component responsiveness #11272 #11306

Gurdeep75way · 2025-03-15T08:28:21Z

Proposed Changes

Fixes Bug: Adjust organization users cards for Tablet #11272
Added min-width to user cards to prevent overlapping on smaller screens
Adjusted avatar size, text, and padding for improved mobile responsiveness
Ensured smooth scaling across all breakpoints

https://drive.google.com/file/d/1jyk18p8OpJYxPtMTAd3s81SqI0OHZOk6/view?usp=sharing

@Jacobjeevan, kindly review this PR and let me know if any changes are required.
@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA in Mobile Devices
Completion of QA in Desktop Devices

Summary by CodeRabbit

Style
- Enhanced the user interface layout for organization users to provide a more consistent, responsive design.
- Refined card spacing, text appearance, and avatar presentation for improved readability and visual balance.
- Updated loading states and user card rendering for better visual presentation.

coderabbitai · 2025-03-15T08:28:29Z

Walkthrough

This pull request modifies the layout and styling in the OrganizationUsers.tsx file. It adjusts the grid classes for responsive behavior by replacing larger breakpoints with sm:grid-cols-2 for both the loading state and user cards. Additionally, the Card component and its content are restyled with class changes—such as adding max-w-full, overflow-hidden, and adjusting padding and gap values—as well as updating the header and status indicator elements to improve text truncation, line height, and layout behavior.

Changes

File(s)	Change Summary
`src/pages/Organization/OrganizationUsers.tsx`	- Replaced `md:grid-cols-2` and `xl:grid-cols-3` with `sm:grid-cols-2` for both loading skeleton and user cards. - Updated `Card` component classes to include `max-w-full` and `overflow-hidden`. - Adjusted `CardContent` padding and gap classes. - Modified header text styling with `leading-tight` and `truncate` and added `flex-shrink-0` to the status indicator.

Assessment against linked issues

Objective	Addressed	Explanation
Adjust organization users cards for Tablet (#[11272])	✅

Possibly related PRs

fix: Organization Users page needs responsiveness #10413 – Layout changes in OrganizationUsers.tsx closely mirror these updates.
fixed User Card Layout Issue – Improper Text Overflow #10984 – Modifications to the user card layout are related to addressing text overflow issues.
Profile redirection in Users Card and Design sync with dept Users design #10659 – Changes in layout structure and navigation components in UserCard are relevant to this PR.

Suggested labels

needs review, tested

Suggested reviewers

Jacobjeevan
rithviknishad

Poem

I'm a bunny with a zest for code,
Hopping through grids where styles have flowed,
Cards now shine with a neat debut,
Shrinking gaps and headers anew,
With every change I twitch my nose,
Celebrating updates as the code garden grows!
🐰💻

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
- To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2a94f3e and cf0039d.

📒 Files selected for processing (1)

src/pages/Organization/OrganizationUsers.tsx (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/pages/Organization/OrganizationUsers.tsx

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-03-15T08:28:44Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`cf0039d`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67d7d9dcb2fa770008a4c3b6
😎 Deploy Preview	https://deploy-preview-11306.preview.ohc.network
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mnshrm · 2025-03-15T10:16:08Z

Hey @Gurdeep75way,
Please change your PR title to something easily understandable, like 'Fixes for OrganizationUsers.tsx component responsiveness'.

Regards,
Aman Sharma

Gurdeep75way · 2025-03-15T10:37:06Z

@mnshrm Done ✅

Jacobjeevan

The footer need to be adjusted as well.

Jacobjeevan · 2025-03-17T07:29:27Z

src/pages/Organization/OrganizationUsers.tsx

-                    <div className="flex items-start gap-3">
+                <Card
+                  key={userRole.id}
+                  className="flex flex-col max-w-full overflow-hidden"


why overflow hidden?

gurdeep-singh-3251s added 2 commits March 14, 2025 08:18

fix: Add min-width to user cards for responsiveness ohcnetwork#11272

c3a9304

Fix: Add min-width to user cards for responsiveness (ohcnetwork#11272)

2a94f3e

Gurdeep75way requested a review from a team as a code owner March 15, 2025 08:28

Gurdeep75way changed the title ~~Issues/11272/fix user card responsive~~ Fixes for OrganizationUsers.tsx component responsiveness #11272 Mar 15, 2025

Jacobjeevan reviewed Mar 17, 2025

View reviewed changes

Jacobjeevan added the changes required label Mar 17, 2025

Fix: Add min-width to user cards for responsiveness (ohcnetwork#11272)

cf0039d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes for OrganizationUsers.tsx component responsiveness #11272 #11306

Fixes for OrganizationUsers.tsx component responsiveness #11272 #11306

Gurdeep75way commented Mar 15, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 15, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Mar 15, 2025 •

edited

Loading

mnshrm commented Mar 15, 2025

Gurdeep75way commented Mar 15, 2025

Jacobjeevan left a comment

Jacobjeevan Mar 17, 2025

Fixes for OrganizationUsers.tsx component responsiveness #11272 #11306

Are you sure you want to change the base?

Fixes for OrganizationUsers.tsx component responsiveness #11272 #11306

Conversation

Gurdeep75way commented Mar 15, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

Summary by CodeRabbit

coderabbitai bot commented Mar 15, 2025 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Mar 15, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

mnshrm commented Mar 15, 2025

Gurdeep75way commented Mar 15, 2025

Jacobjeevan left a comment

Choose a reason for hiding this comment

Jacobjeevan Mar 17, 2025

Choose a reason for hiding this comment

Gurdeep75way commented Mar 15, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 15, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Mar 15, 2025 •

edited

Loading