Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switched to ubuntu-24.04-arm runners #10026

Merged
merged 6 commits into from
Jan 24, 2025
Merged

switched to ubuntu-24.04-arm runners #10026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
536bfe9
switched to ubuntu-24.04-arm runners
tellmeY18 Jan 17, 2025
71f21d0
Merge branch 'develop' into vysakh/upgrade-runners
tellmeY18 Jan 17, 2025
005de1a
resolved missing mentions ubuntu-latest
tellmeY18 Jan 17, 2025
d7321bd
Merge branch 'develop' into vysakh/upgrade-runners
tellmeY18 Jan 23, 2025
f0bc64a
Updated upload artifact version
tellmeY18 Jan 23, 2025
ee2afe4
Updated code-QL workflow to use x86 runners
tellmeY18 Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/auto-testing-label.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:

jobs:
auto_label:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
tellmeY18 marked this conversation as resolved.
Show resolved Hide resolved

steps:
- name: Check PR Conditions and Add Label
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/combine.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ permissions:

jobs:
combine-prs:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix incorrect runner label format

The runner label ubuntu-24.04-arm is invalid and will cause workflow failures. GitHub Actions requires separate labels for the OS and architecture.

Apply this diff to fix the runner configuration:

-    runs-on: ubuntu-24.04-arm
+    runs-on: 
+      - ubuntu-24.04
+      - self-hosted
+      - linux
+      - arm64
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
runs-on: ubuntu-24.04-arm
runs-on:
- ubuntu-24.04
- self-hosted
- linux
- arm64
🧰 Tools
🪛 actionlint (1.7.4)

13-13: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)


steps:
- name: Combine dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/comment-p1-issues.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
jobs:
add-comment:
if: github.event.label.name == 'P1' && github.repository == 'ohcnetwork/care_fe'
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
permissions:
issues: write
steps:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/cypress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
cypress-run:
permissions: write-all
if: github.repository == 'ohcnetwork/care_fe'
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
tellmeY18 marked this conversation as resolved.
Show resolved Hide resolved
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -77,14 +77,14 @@ jobs:
SPLIT_INDEX: ${{ strategy.job-index }}

- name: Upload cypress screenshots on failure 📸
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure()
with:
name: cypress-screenshots
path: cypress/screenshots

- name: Upload cypress videos 📹
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ failure() && steps.pr_origin.outputs.is_forked == 'true' }}
with:
name: cypress-videos
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ env:
jobs:
test:
if: github.repository == 'ohcnetwork/care_fe'
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
name: Test
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -63,7 +63,7 @@ jobs:
needs: test
if: github.ref == 'refs/heads/develop' || startsWith(github.event.ref, 'refs/tags/v')
name: Build & Push to container registries
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
steps:
- uses: actions/checkout@v4

Expand Down Expand Up @@ -133,7 +133,7 @@ jobs:
needs: build
if: startsWith(github.event.ref, 'refs/tags/v')
name: Notify release
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
steps:
- name: Notify release
run: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/issue-automation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
jobs:
issue_opened_and_reopened:
name: issue_opened_and_reopened
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
tellmeY18 marked this conversation as resolved.
Show resolved Hide resolved
if: github.repository == 'ohcnetwork/care_fe' && github.event_name == 'issues' && github.event.action == 'opened' || github.event.action == 'reopened'
steps:
- name: 'Move issue to "Triage"'
Expand All @@ -22,7 +22,7 @@ jobs:
status_value: "Triage"
issue_closed:
name: issue_closed
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
if: github.repository == 'ohcnetwork/care_fe' && github.event_name == 'issues' && github.event.action == 'closed'
steps:
- name: 'Moved issue to "Done"'
Expand All @@ -35,7 +35,7 @@ jobs:
status_value: "Done"
issue_assigned:
name: issue_assigned
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
if: github.repository == 'ohcnetwork/care_fe' && github.event_name == 'issues' && github.event.action == 'assigned'
steps:
- name: 'Move issue to "In Progress"'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/label-deploy-failed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:

jobs:
auto-label-deploy-failed:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix incorrect runner label format

The runner label ubuntu-24.04-arm is invalid and will cause workflow failures. GitHub Actions requires separate labels for the OS and architecture.

Apply this diff to fix the runner configuration:

-    runs-on: ubuntu-24.04-arm
+    runs-on: 
+      - ubuntu-24.04
+      - self-hosted
+      - linux
+      - arm64
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
runs-on: ubuntu-24.04-arm
runs-on:
- ubuntu-24.04
- self-hosted
- linux
- arm64
🧰 Tools
🪛 actionlint (1.7.4)

14-14: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

if: |
github.repository == 'ohcnetwork/care_fe' && github.event.issue.pull_request &&
contains(github.event.comment.body, 'Deploy Preview')
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/label-merge-conflict.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:
jobs:
auto-label:
if: github.repository == 'ohcnetwork/care_fe'
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
steps:
- uses: prince-chrismc/label-merge-conflicts-action@v2
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/label-wip.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
check-linked-issues:
if: github.repository == 'ohcnetwork/care_fe'
name: Check linked issues
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
outputs:
linked_issues: ${{ steps.issue-output.outputs.linked_issues }}
steps:
Expand All @@ -26,7 +26,7 @@ jobs:

label-issues:
name: Label linked issues
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
needs: check-linked-issues
permissions: write-all
if: github.repository == 'ohcnetwork/care_fe' && join(needs.check-linked-issues.outputs.linked_issues) != ''
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:

jobs:
lint:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix incorrect runner label format

The runner label ubuntu-24.04-arm is invalid and will cause workflow failures. GitHub Actions requires separate labels for the OS and architecture.

Apply this diff to fix the runner configuration:

-    runs-on: ubuntu-24.04-arm
+    runs-on: 
+      - ubuntu-24.04
+      - self-hosted
+      - linux
+      - arm64
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
runs-on: ubuntu-24.04-arm
runs-on:
- ubuntu-24.04
- self-hosted
- linux
- arm64
🧰 Tools
🪛 actionlint (1.7.4)

12-12: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

permissions:
contents: read
packages: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/notify-non-core-qn.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ permissions:

jobs:
notify_core_team:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
tellmeY18 marked this conversation as resolved.
Show resolved Hide resolved
env:
ALLOWED_USERNAMES: ${{ vars.ALLOWED_USERNAMES || '' }}
QUESTION_KEYWORDS: ${{ vars.QUESTION_KEYWORDS || '' }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/stale.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:

jobs:
stale:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
if: github.repository == 'ohcnetwork/care_fe'
steps:
- uses: actions/stale@v6
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/thank-you.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
jobs:
if_merged:
if: github.event.pull_request.merged == true
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
tellmeY18 marked this conversation as resolved.
Show resolved Hide resolved
permissions:
issues: write
pull-requests: write
Expand Down
Loading