Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neurological Tables having incorrect vertical heights for table values causing it to have extra whitespace at the bottom #8265

Closed
rithviknishad opened this issue Aug 7, 2024 · 6 comments · Fixed by #8386
Assignees

Comments

@rithviknishad
Copy link
Member

rithviknishad commented Aug 7, 2024

Originally posted by @nihal467 in #8119 (comment)

Describe the bug
Neurological Tables having incorrect vertical heights for table values causing it to have extra whitespace at the bottom

To Reproduce
Steps to reproduce the behavior:

  1. Go to a patient's consultation dashboard
  2. File a log update whose round type is "Detailed Update" with the Neurological Monitoring section filled.
  3. See the Neuro tab in the consultation dashboard (or see this consultation)

Expected behavior
Vertical heights should be correct.

Screenshots
image

@0xvish
Copy link
Contributor

0xvish commented Aug 7, 2024

May I take up this issue please?

@rithviknishad
Copy link
Member Author

@thevishvammoliya Any updates on this?

@0xvish
Copy link
Contributor

0xvish commented Aug 20, 2024

@thevishvammoliya Any updates on this?

On it, had been facing some issues due to inconsistencies in the code, shall I re-develop it with other layout?

@rithviknishad
Copy link
Member Author

Yup! That'd be nice! Ensure the new re-developed one has proper type-safety and also drop a UI mockup here before working on it.

@0xvish
Copy link
Contributor

0xvish commented Aug 21, 2024

I think it can be solved by adjusting some padding and line height values, do these look good?
image
image

@rithviknishad
Copy link
Member Author

Yup!

@rithviknishad rithviknishad moved this from Triage to In Progress in Care Aug 21, 2024
@rithviknishad rithviknishad moved this from In Progress to Up Next in Care Aug 21, 2024
@rithviknishad rithviknishad moved this from Up Next to In Progress in Care Aug 21, 2024
@rithviknishad rithviknishad moved this from In Progress to Review required in Care Aug 21, 2024
@github-project-automation github-project-automation bot moved this from Review required to Done in Care Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants