Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add qodana CI checks (#2607)" #2612

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

sainak
Copy link
Member

@sainak sainak commented Nov 21, 2024

This reverts commit 7986fdd.

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

Summary by CodeRabbit

  • Chores
    • Removed the Qodana workflow for code quality analysis from GitHub Actions.
    • Deleted the configuration file for the Qodana static code analysis tool, which included settings for Python projects.

@sainak sainak requested a review from a team as a code owner November 21, 2024 14:14
Copy link

coderabbitai bot commented Nov 21, 2024

📝 Walkthrough

Walkthrough

The pull request involves the deletion of two files: .github/workflows/qodana_code_quality.yml and qodana.yaml. The former defined a GitHub Actions workflow for code quality analysis using Qodana, while the latter contained configuration settings for the Qodana static analysis tool for Python projects. Both removals indicate a significant step back from automated code quality checks and static analysis capabilities.

Changes

File Path Change Summary
.github/workflows/qodana_code_quality.yml Removed workflow for Qodana code quality analysis.
qodana.yaml Removed configuration file for Qodana static analysis.

Poem

In the land of code where quality thrived,
Two files departed, no longer alive.
The workflow and config, now lost in the mist,
A step back, it seems, from the quality list.
Goodbye, dear Qodana, we bid you adieu,
May your absence be felt, as we start anew! 🌪️✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 2970fe1 and 70a054f.

📒 Files selected for processing (2)
  • .github/workflows/qodana_code_quality.yml (0 hunks)
  • qodana.yaml (0 hunks)
💤 Files with no reviewable changes (2)
  • .github/workflows/qodana_code_quality.yml
  • qodana.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.55%. Comparing base (e901333) to head (70a054f).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2612      +/-   ##
===========================================
+ Coverage    69.53%   69.55%   +0.02%     
===========================================
  Files          212      212              
  Lines        11966    11966              
  Branches      1208     1208              
===========================================
+ Hits          8320     8323       +3     
+ Misses        3277     3274       -3     
  Partials       369      369              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@vigneshhari vigneshhari merged commit d23cbcb into develop Nov 21, 2024
8 checks passed
@vigneshhari vigneshhari deleted the sainak/remove-qodana branch November 21, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants