Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Develop To Staging v24.48.0 #2606

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Merge Develop To Staging v24.48.0 #2606

merged 7 commits into from
Nov 20, 2024

Conversation

nihal467
Copy link
Member

Proposed Changes

  • Brief of changes made.

Associated Issue

  • Link to issue here, explain how the proposed solution will solve the reported issue/ feature request.

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

DraKen0009 and others added 3 commits November 14, 2024 19:45
added test cases for asset bed (#2532)
added tests for patient transfer (#2564)
Clean up asset classes (#2494)
---------

Co-authored-by: Aakash Singh <[email protected]>
Copy link

coderabbitai bot commented Nov 20, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

qodana-cloud bot and others added 2 commits November 20, 2024 14:08
* Add qodana.yaml file

* Add github workflow file

* Update qodana_code_quality.yml

---------

Co-authored-by: Qodana Application <[email protected]>
Co-authored-by: Vignesh Hari <[email protected]>
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 63.46154% with 19 lines in your changes missing coverage. Please review.

Project coverage is 69.53%. Comparing base (d6d069e) to head (e901333).
Report is 53 commits behind head on staging.

Files with missing lines Patch % Lines
care/utils/assetintegration/onvif.py 20.00% 8 Missing ⚠️
care/utils/assetintegration/hl7monitor.py 40.00% 3 Missing ⚠️
care/utils/assetintegration/ventilator.py 40.00% 3 Missing ⚠️
care/facility/api/serializers/asset.py 33.33% 2 Missing ⚠️
care/utils/assetintegration/base.py 90.00% 2 Missing ⚠️
care/facility/api/viewsets/asset.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2606      +/-   ##
===========================================
+ Coverage    69.20%   69.53%   +0.32%     
===========================================
  Files          211      212       +1     
  Lines        11944    11966      +22     
  Branches      1208     1208              
===========================================
+ Hits          8266     8320      +54     
+ Misses        3302     3277      -25     
+ Partials       376      369       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

github-actions bot commented Nov 20, 2024

Qodana for Python

1076 new problems were found

Inspection name Severity Problems
Improper first parameter 🔴 Failure 1
Incorrect type 🔶 Warning 46
Attempt to call a non-callable object 🔶 Warning 16
Incorrect call arguments 🔶 Warning 6
Unbound local variables 🔶 Warning 6
Redeclared names without usages 🔶 Warning 2
Invalid type hints definitions and usages 🔶 Warning 2
Unused local symbols ◽️ Notice 415
PEP 8 naming convention violation ◽️ Notice 197
Method is not declared static ◽️ Notice 150
Duplicated code fragment ◽️ Notice 87
Improper first parameter ◽️ Notice 41
An instance attribute is defined outside init`` ◽️ Notice 34
Class has no init method ◽️ Notice 29
Accessing a protected member of a class or a module ◽️ Notice 20
Shadowing names from outer scopes ◽️ Notice 9
Redundant parentheses ◽️ Notice 5
Assigning function calls that don't return anything ◽️ Notice 3
Too complex chained comparisons ◽️ Notice 2
Incorrect docstring ◽️ Notice 2
Unclear exception clauses ◽️ Notice 1
Dictionary creation can be rewritten by dictionary literal ◽️ Notice 1
Vulnerable declared dependency ◽️ Notice 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

* modified the users and patient names

* missed out one patient name

* missed out one patient name
@rithviknishad rithviknishad merged commit a01b90b into staging Nov 20, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants