-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flushed care_static_data prefixed redis keys #2572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reference delete_pattern from cache backend
use itersize=25_000, to speed up the operation
2eec421
to
f257af7
Compare
f257af7
to
f6172f9
Compare
* Used delete_pattern from django-redis repo to delete keys
f6172f9
to
1b0b484
Compare
All the requested changes should be in place now 👍 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2572 +/- ##
===========================================
- Coverage 69.26% 69.19% -0.07%
===========================================
Files 211 211
Lines 11928 11940 +12
Branches 1208 1208
===========================================
Hits 8262 8262
- Misses 3290 3302 +12
Partials 376 376 ☔ View full report in Codecov by Sentry. |
If the data load fails, we will end up with no data in the system, this is a flaw. An ideal implementation would only delete stale items maintaining the existing data somehow. |
Proposed Changes
care_static_data
prefixAssociated Issue
prefix care_static_data
within try/catch blocks to prevent uncaught exceptions.Merge Checklist
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins