Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error if doctor is not linked to the consultation facility #2309

Merged
merged 6 commits into from
Aug 25, 2024

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented Jul 17, 2024

Proposed Changes

  • Adds an error message if the doctor is not associated to the facility anymore

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@shivankacker shivankacker requested a review from a team as a code owner July 17, 2024 14:26
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.73%. Comparing base (ac7f696) to head (e32d015).
Report is 1 commits behind head on develop.

Files Patch % Lines
...e/facility/api/serializers/patient_consultation.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2309      +/-   ##
===========================================
+ Coverage    63.70%   63.73%   +0.02%     
===========================================
  Files          238      238              
  Lines        13316    13342      +26     
  Branches      1897     1904       +7     
===========================================
+ Hits          8483     8503      +20     
- Misses        4481     4486       +5     
- Partials       352      353       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shivankacker shivankacker requested a review from sainak July 18, 2024 19:04
@sainak sainak requested a review from rithviknishad August 13, 2024 13:31
@vigneshhari vigneshhari merged commit 44e1618 into develop Aug 25, 2024
8 checks passed
@vigneshhari vigneshhari deleted the non-facility-error branch August 25, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the Error for Consultation Form
3 participants