Fix op number constraint for readmitted patients

[shivankacker]

Proposed Changes

• Fixes Remove all OP number validation  care_fe#7751

Merge Checklist

• Tests added/fixed
• Update docs in /docs
• Linting Complete
• Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

[sainak]

@skks1212 add test for the cases mentioned in the issue

[nihal467]

@skks1212 the PR is not working as expected

Test Case Status : failed

• Same IP number for re-admitted patient within the facility { It should throw error }
• Same OP number for re-admitted patient within the facility
• Use Earlier IP number for re-admitted patient within the facility and his latest OP number for domiciliary care
• OP number is unique for different patient within the facility
• OP number can be modified to match previous consultation OP number

Bug

• unable to create OP patients with same OP number

• When we re-admit same patient to the same facility with same IP number , it is throw "something went wrong" error, reuse the existing error shown for unique IP number

• when we re-admit same patient to the same facility using his earlier IP number (Admission) as the latest OP number (Domiciliary Care), it is throw "something "

[shivankacker]

PR was incomplete, forgot to label as wip 😅. Fixing now

[nihal467]

@skks1212 the PR is still having bugs, I can create multiple consultation with same IP number for a single patient within a facility

[nihal467]

As per the issue , we are removing Data validation on the OP No. field.

[nihal467]

when a patient is discharged, and we reuse the same IP for next patient, it is being accept

Note: When a patient is live, and we try to reuse the IP for a new patient, this error is thrown properly

[sainak]

test case required

[nihal467]

LGTM

[vigneshhari]

I still think we need a unique validator across patients, as in two live patients cannot have the same IP/OP number