Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improving tests for patient transfer #2066

Closed
wants to merge 2 commits into from
Closed

improving tests for patient transfer #2066

wants to merge 2 commits into from

Conversation

DraKen0009
Copy link
Contributor

Proposed Changes

  • Added extra tests to improve test coverage of patients

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@DraKen0009 DraKen0009 requested a review from a team as a code owner April 9, 2024 06:07
@sainak
Copy link
Member

sainak commented Apr 18, 2024

@DraKen0009 this will require more tests as there are multiple scenarios for transfers based on user and wartime/peacetime mode

@nihal467 can you help him with the har logs for the transfer module

sainak
sainak requested changes Apr 18, 2024
View reviewed changes
Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to cover more scenarios

@sainak
Copy link
Member

sainak commented Apr 18, 2024

for more info run coverage on https://github.com/coronasafe/care/blob/2c023e1d06c694157a32fcecc11f9b6d051e1d75/care/facility/api/serializers/shifting.py#L236-L415

@sainak sainak added the to-be-closed PRs with no updates in the last 3 weeks will be closed label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sainak sainak sainak requested changes

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees
No one assigned
Labels
to-be-closed PRs with no updates in the last 3 weeks will be closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve tests for Patient Transfer
4 participants
@DraKen0009 @sainak @rithviknishad @vigneshhari