Skip to content

fix(vectordb): VectorDBInput has no provider_id #2830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leseb merged 1 commit into from
Jul 21, 2025
Merged

fix(vectordb): VectorDBInput has no provider_id #2830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions llama_stack/apis/vector_dbs/vector_dbs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ class VectorDBInput(BaseModel):
vector_db_id: str
embedding_model: str
embedding_dimension: int
provider_id: str | None = None
Copy link
Copy Markdown
Collaborator

@leseb leseb Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't provider_id be mandatory? Otherwise, how do we determine to which provider we should be routing to?

Copy link
Copy Markdown
Collaborator

@leseb leseb Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, we have:

        if provider_id is None:
            if len(self.impls_by_provider_id) > 0:
                provider_id = list(self.impls_by_provider_id.keys())[0]
                if len(self.impls_by_provider_id) > 1:
                    logger.warning(
                        f"No provider specified and multiple providers available. Arbitrarily selected the first provider {provider_id}."
                    )

Which seems really arbitrary, but anyways this is a discussion for another time I guess.

Copy link
Copy Markdown
Author

@Elbehery Elbehery Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you kindly raise an issue with the future work ?

Copy link
Copy Markdown
Author

@Elbehery Elbehery Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see u raised #2834

i have signed up for it 👍🏽

provider_vector_db_id: str | None = None


Expand Down
Loading