Skip to content

chore(test): migrate unit tests from unittest to pytest nvidia test safety#2793

Merged
ashwinb merged 1 commit into
ogx-ai:mainfrom
Elbehery:20250717_migrate_unittest_pytest_nvidia_test_safety
Jul 24, 2025
Merged

chore(test): migrate unit tests from unittest to pytest nvidia test safety#2793
ashwinb merged 1 commit into
ogx-ai:mainfrom
Elbehery:20250717_migrate_unittest_pytest_nvidia_test_safety

Conversation

@Elbehery
Copy link
Copy Markdown

This PR replaces unittest with pytest.

Part of #2680

cc @leseb

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 17, 2025
@Elbehery Elbehery changed the title 20250717 migrate unittest pytest nvidia test safety chore(test): migrate unit tests from unittest to pytest nvidia test safety Jul 17, 2025
@Elbehery Elbehery force-pushed the 20250717_migrate_unittest_pytest_nvidia_test_safety branch from ea9d030 to acd6d3e Compare July 17, 2025 10:19
Comment thread tests/unit/providers/nvidia/test_safety.py Outdated
@Elbehery Elbehery force-pushed the 20250717_migrate_unittest_pytest_nvidia_test_safety branch 2 times, most recently from cac9c07 to 3f19c29 Compare July 18, 2025 15:20
@Elbehery
Copy link
Copy Markdown
Author

failure in integration test requires the changes in #2678

@Elbehery
Copy link
Copy Markdown
Author

failure in integration test requires the changes in #2678

topological sort 🤓

@Elbehery
Copy link
Copy Markdown
Author

the failure are pending on #2815 being merged

@Elbehery Elbehery force-pushed the 20250717_migrate_unittest_pytest_nvidia_test_safety branch 2 times, most recently from 90d7119 to a3b0830 Compare July 23, 2025 12:41
@Elbehery
Copy link
Copy Markdown
Author

rebased 👍🏽

…afety

Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
@Elbehery Elbehery force-pushed the 20250717_migrate_unittest_pytest_nvidia_test_safety branch from a3b0830 to 64e08e3 Compare July 24, 2025 09:30
@Elbehery
Copy link
Copy Markdown
Author

cc @nathan-weinberg @ashwinb @ehhuang ptal :)

@ashwinb ashwinb merged commit 6ab5760 into ogx-ai:main Jul 24, 2025
64 checks passed
@Elbehery Elbehery deleted the 20250717_migrate_unittest_pytest_nvidia_test_safety branch July 24, 2025 17:27
ChristianZaccaria pushed a commit to ChristianZaccaria/llama-stack that referenced this pull request Jul 28, 2025
…afety (ogx-ai#2793)

This PR replaces unittest with pytest.

Part of ogx-ai#2680

cc @leseb

Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants