src: terminate correctly double-quote in env variable

PR-URL: nodejs#51510 Fixes: nodejs#51508 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
ognjenjevremovic · Jan 20, 2024 · 880c90c · 880c90c
1 parent 9a25438
commit 880c90c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/src/node_dotenv.cc b/src/node_dotenv.cc
@@ -142,7 +142,7 @@ void Dotenv::ParseLine(const std::string_view line) {
     auto quote_character = value[quotation_index];
     value.erase(0, 1);
 
-    auto end_quotation_index = value.find_last_of(quote_character);
+    auto end_quotation_index = value.find(quote_character);
 
     // We couldn't find the closing quotation character. Terminate.
     if (end_quotation_index == std::string::npos) {

diff --git a/test/fixtures/dotenv/valid.env b/test/fixtures/dotenv/valid.env
@@ -33,3 +33,4 @@ RETAIN_INNER_QUOTES_AS_BACKTICKS=`{"foo": "bar's"}`
 TRIM_SPACE_FROM_UNQUOTED=    some spaced out string
 EMAIL=[email protected]
     SPACED_KEY = parsed
+EDGE_CASE_INLINE_COMMENTS="VALUE1" # or "VALUE2" or "VALUE3"
diff --git a/test/parallel/test-dotenv.js b/test/parallel/test-dotenv.js
@@ -68,3 +68,5 @@ assert.strictEqual(process.env.TRIM_SPACE_FROM_UNQUOTED, 'some spaced out string
 assert.strictEqual(process.env.EMAIL, '[email protected]');
 // Parses keys and values surrounded by spaces
 assert.strictEqual(process.env.SPACED_KEY, 'parsed');
+// Parse inline comments correctly when multiple quotes
+assert.strictEqual(process.env.EDGE_CASE_INLINE_COMMENTS, 'VALUE1');