-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to stable #85
Move to stable #85
Conversation
Yes. For some reason, 1.3.0 throws this:
|
1.3.0 fails because the scoped_threadpool crate makes that particular method unsafe for that version to work around a bug in rustc that’s since been fixed. More details here: #84 (comment) |
I fixed the tree output by reimplementing resize in terms of a reallocation and a It's certainly not as efficient as the original, but it works. I added a TODO to keep track that this should be cleaned up after the 1.5.0 release. |
Moved the constants to a private module. |
LGTM! 👍 I’m OK with copy-and-pasting code from libstd in lieu of waiting for some of the features to stabilise, especially if these features are already going to be stabilised soon. The benefit of having everyone able to compile exa themselves outweighs the small cost of ever fixing it if we need to. So thanks very much for this. |
doc: Update README.md
This introduces multiple changes to make exa work on Rust 1.4.0. Detailed reasoning behind all patches:
sum
can be trivially replaced byfold(0, Add::add)
, dropping a convenience feature flag.fs_mode
s tracking issue currently gives no hope forfs_mode
to remain as it is or to be stabilized anytime soon. As the only thing imported is a constant table, this can be copied over into the library - it will most likely break in the future anyways.String
instead, which avoids many of the issues described in the corresponding RFC discussion.reserve
instead ofresize
, to my reading. Resize will become available in Rust 1.5.