Skip to content

Commit

Permalink
deps: V8: workaround V8 leak w track constant fields
Browse files Browse the repository at this point in the history
track_constant_fields exposes a large regression in memory leak due
to a suspected memory leak. Disable this until a proper fix is ready.

Ref: https://bugs.chromium.org/p/v8/issues/detail?id=9507
Ref: nodejs#28205
  • Loading branch information
ofrobots committed Jul 17, 2019
1 parent 971915e commit 7f375de
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.15',
'v8_embedder_string': '-node.16',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/flag-definitions.h
Original file line number Diff line number Diff line change
Expand Up @@ -1044,7 +1044,7 @@ DEFINE_IMPLICATION(trace_ic, log_code)
DEFINE_GENERIC_IMPLICATION(
trace_ic, TracingFlags::ic_stats.store(
v8::tracing::TracingCategoryObserver::ENABLED_BY_NATIVE))
DEFINE_BOOL_READONLY(track_constant_fields, true,
DEFINE_BOOL_READONLY(track_constant_fields, false,
"enable constant field tracking")
DEFINE_BOOL_READONLY(fast_map_update, false,
"enable fast map update by caching the migration target")
Expand Down

0 comments on commit 7f375de

Please sign in to comment.