-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: 1.8 ABI compat #10385
core: 1.8 ABI compat #10385
Conversation
@@ -111,7 +111,7 @@ extern "C" { | |||
* name appended with the ABI version that it is compatible with. | |||
*/ | |||
|
|||
#define CURRENT_ABI "FABRIC_1.7" | |||
#define CURRENT_ABI "FABRIC_1.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change indicates that the fi_fabric2() call is not aligned with the documentation in this file. Checking the code, it's using DEFAULT_SYMVER(... FABRIC_1.8) directly instead of CURRENT_SYMVER(). There were also changes to fi_getinfo / fi_freeinfo / fi_dupinfo as part of ABI 1.8 changes. The changes to those functions should be captured in the man page below as well.
If CURRENT_SYMVER() will no longer be used, that macro should be removed and the man page updated to reflect direct use of DEFAULT_SYMVER instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will keep it 1.8 for the 2.0 release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shefty Using DEFAULT_SYMVER() here for the new function instead of CURRENT_SYMVER() has the advantage of showing the exact ABI version at the definition and not needing to change it again when the ABI version is bumped. I think we can remove CURRENT_SYMVER() definition and usage info from the header. If no objection, I will make that change in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to remove CURRENT_SYMVER
ABI version is updated to 1.8 to accommodate fi_fabric2() API. Signed-off-by: Jessie Yang <[email protected]>
Intel CI error is unrelated. |
ABI version is updated to 1.8 to accommodate fi_fabric2() API introduced in #10279