prov/efa: Respect FI_MR_LOCAL in transport path #10348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijin-aws
reviewed
Aug 28, 2024
shijin-aws
approved these changes
Aug 28, 2024
prov/efa/src/rdm/efa_rdm_ope.c
Outdated
Comment on lines
273
to
274
| "No valid desc is provided, not complied with FI_MR_LOCAL." | ||
| "buf: %p len: %ld access: %lx\n", |
There was a problem hiding this comment.
Suggested change
| "No valid desc is provided, not complied with FI_MR_LOCAL." | |
| "buf: %p len: %ld access: %lx\n", | |
| "No valid desc is provided, not compliant with FI_MR_LOCAL. " | |
| "buf: %p len: %ld access: %#lx\n", |
# automatically prepends the conversion with 0x/0X - just now noticing the many instances of %x/%lx in our logs without it.
Currently, efa provider tries to register user buffer in transport in multiple places without checking whether application sets FI_MR_LOCAL, which is not complied with Libfabric standard. Add warning when application sets FI_MR_LOCAL but does not provide a valid desc parameter into applicable data transfer operations. Signed-off-by: Jessie Yang <[email protected]>
darrylabbate
approved these changes
Aug 29, 2024
|
bot:aws:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, efa provider tries to register user buffer in transport in multiple places without checking whether application sets FI_MR_LOCAL, which is not complied with Libfabric standard. Add warning when application sets FI_MR_LOCAL but does not provide a valid desc parameter into applicable data transfer operations.