Fix ucx set/getopt error return and hmem_ze error message #10341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name passed to dlopen() was changed to "libze_loader.so.1" sometime ago but "libze_loader.so" was still used in the error message. That could mislead the debugging process when error happens. Signed-off-by: Jianxin Xiong <[email protected]>
Should return -FI_ENOPROTOOPT for unsupported options. Signed-off-by: Jianxin Xiong <[email protected]>
Merged
This is required for providers that support FI_HMEM. Signed-off-by: Jianxin Xiong <[email protected]>
j-xiong
force-pushed
the
fix-ucx-opt-return
branch
from
19eae86
to
583755a
Compare
|
@shijin-aws Any detail on the AWS CI failure? It passed in the previous run. |
|
@j-xiong We have internal CI flakiness. Please restart test. |
|
bot:aws:retest |
|
Also, the AWS CI failure is unlikely related to this PR. I don't think we need to block merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.