The reproduction of "prov/socket segfaults in sock_ep_connect() when … #606
Conversation
…it tries to dereference dest_addr" issue ofiwg/libfabric#2676 fi_msg_sockets: Add new test case that covers Issue #2676 Invokes fi_send when no connect is established and no destination addres:port pair is passed to fi_info Change-Id: I1a64131eafa882b9f60a725d055ede039ad2250b Signed-off-by: Gladkov, Dmitry <[email protected]>
|
Since fix for Issue #2676 isn't included yet onto master branch, the Travis CI build have failed (new added test have failed) |
| if (ret) { | ||
| FT_PRINTERR("fi_connect", ret); | ||
| free(dest_addr); |
There was a problem hiding this comment.
This needs the same protection as you have below.
| if (ret >= 0) { | ||
| FT_ERR("Unexpected result of fi_send - %d (ep %p)", ret, ep); | ||
| return -FI_EOTHER; | ||
| } |
There was a problem hiding this comment.
I think this is the only piece of new code that's actually needed. You're just wanting to see what happens if fi_send() is called prior to calling connect. Since this is a coding error in the application, most providers are not going to want the overhead of checking the connection on every send call. So an assertion in the provider is better than a run time failure, which would prevent fabtests from actually trying to catch this error.
|
Hi @shefty. Since we've added assert instead of "if" statement. I guess, this test isn't applicable anymore and I can close the pull request. |
The reproduction of "prov/socket segfaults in sock_ep_connect() when it tries to dereference dest_addr" issue
ofiwg/libfabric#2676
fi_msg_sockets: Add new test case that covers Issue #2676
Invokes fi_send when no connect is established and no destination addres:port
pair is passed to fi_info
Signed-off-by: Dmitry Gladkov [email protected]