Skip to content
This repository has been archived by the owner on Nov 22, 2021. It is now read-only.

Upgrade lint #22

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Upgrade lint #22

wants to merge 6 commits into from

Conversation

blakearnold
Copy link
Collaborator

Hi!
Not sure if this is the proper way to submit a patch, but FWIW:

I spent some time trying to get the Android Lint plugin up to speed with version 25.1.2 of android-lint.
This is somewhat of a WIP, but would love some feedback before investing too much more time.
This should fix #17.

Some notes:

  • I modified some of the tests to specify a test-rules.xml so they are not fragile when the real rules.xml gets updated.
  • export_reimport_should_end_up_with_same_quality_profile seemed to be failing even though it was reading in the test-rules.xml. I must have missed something so I've disabled the test for now.
  • I'm not sure how to run the tests under its/plugin/projects, so it's probably broken.
  • This also contains a bug fix to SonarRulesGenerator.java where it was not exporting the tags with the correct xml element
  • Most of the updates to SQALE xml is a hack. The file should probably be cleaned up considering only remediationFunction and offset are used.

In my quick testing, it seems to be working.

-Blake


/**
* Used for testing.
*/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to use annotation @VisibleForTesting instead of a comment.

@benzonico
Copy link

As promised on the mailing list here is a few feedback about this PR.
See my inline comments.

Regarding :

Most of the updates to SQALE xml is a hack. The file should probably be cleaned up considering only remediationFunction and offset are used

Given that this sqale approach was dropped in latest LTS I would not bother too much with it.

Which brings me to the next point for maintainance of this plugin IMO : an effort should be made to upgrade this plugin to java 8 and the latest SQ LTS in order to drop deprecated APIs. (note this is unrelated to this PR directly but most probably required before releasing).

HTH, and good luck with the maintainance of this plugin !

@abvanpelt
Copy link

@tomverin Is this project still active?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to latest version of android lint version 25.1.1 (SONARANDRO-39)
3 participants