Typescript and Engines support #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! Do you mind also updating the readme so it displays actual type information? |
* See emberjs/ember.js#15291 for more details
|
Sorry, to get back to this so late! On the bright side we discovered and fixed another fun bug 😞. @poteto, what are you imagining? I can copy and paste the types, link to the relevant blocks, or both? I'll also throw in a tiny typescript example in the README as the usage might not be super straight forward. |
|
No worries @chrisseto!
Copy and paste should be just fine.
That would be great, ty! |
|
Released under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up/correction to #59.
Looking like the issue was with making
deserializealways return a promise. Now a promise is only returned if the handlers have not been resolved already.@offirgolan I wasn't able to find a difference between this implementation and the hosted dummy app. Would you mind double checking whenever you get a chance?