add macOS and windows to CI #3623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- macOS
- system clang
- gcc
- windows / msys2
- mingw 64-bit gcc
- mingw 32-bit gcc
- minor code fixes to get new CI jobs to pass
- suppress unused-parameter warning on 32-bit windows
- Makefile
- on macos use 'x86-64' in place of 'any' for arch
- avoids clang compiler error: "invalid arch name '-arch any'"
vondele
reviewed
Jul 21, 2021
src/Makefile
Outdated
| arch = x86_64 | ||
| sse = yes | ||
| sse2 = yes | ||
| endif |
There was a problem hiding this comment.
can this be avoided in a different way? Probably general-64 should not be specifying the architecture at all, like could this fail on M1?
|
Looks good to me. Thanks! |
|
so, thanks this looks good, will merge shortly, adding your name to AUTHORS. This is a nice contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2958