Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify LMR #3460

Closed
wants to merge 1 commit into from
Closed

Conversation

BM123499
Copy link
Contributor

Simplify LMR as it seems not to bring any strength and thus is no longer needed..

elo estimative test:
https://tests.stockfishchess.org/tests/view/609af2a63a33eb67a844f867

STC:
LLR: 2.94 (-2.94,2.94) <-2.50,0.50>
Total: 55256 W: 4972 L: 4897 D: 45387
Ptnml(0-2): 177, 3976, 19234, 4077, 164
https://tests.stockfishchess.org/tests/view/609adf3b3a33eb67a844f842

LTC:
LLR: 2.95 (-2.94,2.94) <-2.50,0.50>
Total: 10344 W: 437 L: 353 D: 9554
Ptnml(0-2): 1, 322, 4449, 392, 8
https://tests.stockfishchess.org/tests/view/609b3dfa3a33eb67a844f88e

bench: 3840688

bench: 3840688
@snicolet
Copy link
Member

I dont understand the "Elo estimative test"
It is not the same patch nor the same bench?

@BM123499
Copy link
Contributor Author

Elo estimative test is feed back I have from other simplification that failed. Basically, I'm reevaluating estimates from #2401 that was made before NNUE.

@snicolet snicolet closed this in 594e2ac May 12, 2021
@snicolet
Copy link
Member

Merged via 594e2ac, congrats :-)

@snicolet snicolet added the to be merged Will be merged shortly label May 12, 2021
BM123499 added a commit to BM123499/Stockfish that referenced this pull request May 18, 2021
We simplify away the complicated rule in LMR for "non-checking captures
likely to be bad", as it seems not to bring any strength anymore.

STC:
LLR: 2.94 (-2.94,2.94) <-2.50,0.50>
Total: 55256 W: 4972 L: 4897 D: 45387
Ptnml(0-2): 177, 3976, 19234, 4077, 164
https://tests.stockfishchess.org/tests/view/609adf3b3a33eb67a844f842

LTC:
LLR: 2.95 (-2.94,2.94) <-2.50,0.50>
Total: 10344 W: 437 L: 353 D: 9554
Ptnml(0-2): 1, 322, 4449, 392, 8
https://tests.stockfishchess.org/tests/view/609b3dfa3a33eb67a844f88e

--

While at it, we also update the Elo estimate of the previous rule in LMR
(see https://tests.stockfishchess.org/tests/view/609af2a63a33eb67a844f867).

closes official-stockfish#3460

Bench: 3840688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to be merged Will be merged shortly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants