Modify loot-to-crate to dump all leftovers to a single weapon holder #3462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this.
What have you changed and why?
Reworked loot-to-crate to dump all the leftovers to a single weapon holder next to the looting crate. This has some likely client performance & networking advantages, and enabled easier detection of whether the leftover weapon holder could be deleted as a priority (due to only containing unlocked items).
The original code didn't differentiate between the crate-full and already-unlocked cases when looting items from bodies (only when looting other weapon holders), and there was a danger of all the additional weapon holders (typically 2-3 per corpse) filling up the postmortem queue and causing premature deletion of corpses.
As far as I can tell I didn't break anything new in the process. Test cases:
Please specify which Issue this PR Resolves.
closes #3447
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?
Someone else should probably test it and see if they can break anything.