Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHS HIDF, TLA, NVG fix #3457

Merged

Conversation

ante185
Copy link

@ante185 ante185 commented Dec 8, 2024

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Information:
Removes blank entry from HIDF (It was giving them vanilla NVGs)
Flagged HIDF and TLA as lowTech

Please specify which Issue this PR Resolves.

closes #XXXX

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:


Notes:

@ante185 ante185 added Bug Something isn't working Review pending Templates Items related to templates labels Dec 8, 2024
@ante185 ante185 added this to the 3.8.0 milestone Dec 8, 2024
@ante185 ante185 requested a review from jaj22 December 8, 2024 17:33
@jaj22
Copy link
Collaborator

jaj22 commented Dec 9, 2024

Does lowTech make sense here? I don't know the lore of these factions, and the only ones we have with lowTech at the moment are Vietnam & WW2.

@ante185
Copy link
Author

ante185 commented Dec 10, 2024

dropped low tech flag pending info on what it do

Copy link

@Play3rgg Play3rgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ante185 ante185 changed the title RHS HIDF, TLA, NVG fix, low tech flag RHS HIDF, TLA, NVG fix Dec 10, 2024
@Bob-Murphy Bob-Murphy merged commit c8cc9d5 into official-antistasi-community:unstable Dec 13, 2024
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added to changelog Added to changelog Bug Something isn't working Ready for merge Templates Items related to templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants