Skip to content

Make solph 0.5.1 work #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 3, 2023
Merged

Make solph 0.5.1 work #107

merged 9 commits into from
Jul 3, 2023

Conversation

nailend
Copy link
Collaborator

@nailend nailend commented Jun 29, 2023

closes #105

  • checked and adjusted LP file notations
  • checked and added new multi-period constraints
  • adjusted Link import

nailend added 5 commits June 28, 2023 17:04
@nailend
Adjust link imports
52779c3
@nailend
Adjust simple test LP-file changes
22a9cb6 
Due to the mult-period approach, the flow  notations
of timesteps changed to postfix `_period_timestep`.
Most of this were executed.
@nailend
Adapt simple investment constraints in LP files
97d9fb4
@nailend
Adjust complex investestment test LP-files
7d7c635
@nailend
Revert "Skip Link test temporarily"
d3438be 
This reverts commit c54fdae.
@nailend nailend requested a review from henhuy June 29, 2023 12:31
@nailend nailend self-assigned this Jun 29, 2023
nailend added 3 commits June 29, 2023 14:34
@nailend
Bump oemof.solph version to v.0.5.1
5ba6313
@nailend
Use workaround for not release oemof.solph version
baff985 
The current dev branch of oemof.solph is used to have tests running in
github actions as there is not yet an pypi or github release.
@nailend
Isort
eab3beb
@nailend
Copy link
Collaborator Author

nailend commented Jun 29, 2023 •
edited
Loading

I added the current dev branch of omeof.solph to the install requirements, to run the tests. This should not be merge to dev, adjusted to v.0.5.1.dev2 tag as soon as the github release is out and removed as soon as the pypi release is out.

henhuy
henhuy approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@henhuy henhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked LP files.
Had to wrap my mind around changed formulas first, but IMO they are still corrrect.
Tests run trough - thanks a lot!

@nailend nailend merged commit 8429a9b into dev Jul 3, 2023
@nailend nailend deleted the features/make-solph-0.5.1-work branch July 3, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henhuy henhuy henhuy approved these changes

Assignees

@nailend nailend

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make tabular work with solph v0.5.1
2 participants
@nailend @henhuy