Repository navigation
fix(vite): score crashed rules as not-run on the dev dashboard, matching CLI and build mode - #475
Merged
oekazuma merged 2 commits intoAug 12, 2026
Conversation
…ing CLI and build mode The dev dashboard's whole-project runner and live per-route ingest both discarded runRules' failedRules, so a crashed rule silently inflated Health there while the CLI and vite build path already excluded it via withFailedRulesOff. Thread the failure-adjusted config through both layers (static: analyzeProject's returned config via a closure the middleware reads per-request; live: failedRuleIds on the ingest payload, unioned in the store) and apply withFailedRulesOff where the snapshot is built. Also extracts formatFailedRuleWarning to core (replacing three copy-pasted "rule ... failed and was skipped" string literals, one of which had drifted and lost the first-line cap) and wraps the vite plugin/handle's warn sinks with terminalSafe. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…d-rule ids instead Revision to the previous commit: buildSnapshot's staticConfig param silently dropped plugin-option weights/overrides once the first whole-project run completed, since analyzeProject's returned config never saw those plugin-only values. Replace the config-swap with an ids-only contract: analyzeProject now also returns failedRuleIds (already folded into its own returned config via withFailedRulesOff, exposed separately for callers with their own base config); the vite runner/plugin/snapshot/middleware thread that id list instead of a Config, so the dashboard's base config — and any plugin-option weights/overrides it carries — is never swapped, only layered with withFailedRulesOff. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #473 — merge that first; GitHub will retarget this to main when the base branch is deleted.
PR #464 made a crashed rule count as "did not run" on the CLI and vite build paths, but the dev dashboard — the most-watched surface — got neither half: the whole-project runner discarded everything but `results`, the live ingest never forwarded `failedRules`, and the middleware scored every snapshot with the unadjusted plugin config. A crashed rule silently inflated the dashboard's Health, and CLI vs dashboard disagreed on the same project.
Full chain green on this branch (core 1439 / cli 1161 / vite 230, build+typecheck+lint). Plan: `plans/052-dashboard-failed-rules.md`.
🤖 Generated with Claude Code