Repository navigation
feat(core): align SEO severities with their evidence #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| --- | ||
| '@svelte-vitals/core': minor | ||
| --- | ||
|
|
||
| The CLI's default gate is `--fail-on critical`: a project failing only on a missing | ||
| `<meta name="description">` now exits `0` instead of `1` (a deliberate loosening). Three more gate | ||
| movements only surface under a non-default `--fail-on warning` (or an equivalent `--min-health`): | ||
| a project failing only on a missing `og:url` now exits **`1` instead of `0` — a tightening, and the | ||
| only one of the four that can turn a previously-green CI red on upgrade.** A project failing only | ||
| on a missing `og:description` now exits `0` instead of `1`. A project failing only on a | ||
| multi-`<h1>` page now also exits `0` instead of `1`. No other rule's severity changed, so no other | ||
| gate behavior changes. Realigned four SEO rule severities with their underlying evidence, | ||
| following the 2026-08-09 rule-validity review's Priority-2 findings. | ||
|
|
||
| Two of the four changes shrink the `seo::route` scoring pair's total weight from 110 to 100 | ||
| (description-presence −10, og-url +4, og-description −4, net −10) — so a project's SEO/Health | ||
| score can shift by a point or two even with no finding changes at all, simply because the | ||
| denominator moved. `single-h1` and `hreflang` don't affect the pair's weight (see below). | ||
|
|
||
| - `seo/description-presence`: `critical` → `warning`. `critical` now uniformly means | ||
| deploy-blocking (the four crash/security rules — `correctness/orphan-effect`, | ||
| `correctness/orphan-lifecycle`, `correctness/server-browser-global`, | ||
| `security/handler-state-write` — plus `seo/title-presence`) — Google only "sometimes" uses the | ||
| provided meta description for the search snippet, generating one from page content the rest of | ||
| the time, so a missing one is real but non-blocking. | ||
| - `seo/og-url`: `info` → `warning`, and `seo/og-description`: `warning` → `info` — swapped to match | ||
| the [Open Graph protocol](https://ogp.me/)'s own required/optional split (`og:url` is Basic/required | ||
| metadata; `og:description` is Optional). The previous ordering's "og:url is covered by canonical" | ||
| rationale conflated two different jobs (canonical targets search engines, og:url targets social | ||
| platforms) and is now recorded as historical context in the `og:url` docs page. | ||
| - `seo/single-h1`: severity split — a page with zero `<h1>` stays `warning` (a real primary-heading | ||
| gap); two or more `<h1>` is demoted to `info` (a single `<h1>` is the conventional signal, but no | ||
| official source documents a ranking penalty for several, so it's a style nit, not a defect). The | ||
| rule's own registered severity (read by scoring's inventory and the rules index) stays `warning` | ||
| — only the per-finding severity is split, so the `seo::route` pair's total weight is unaffected. | ||
| A global `rules: { 'seo/single-h1': <severity> }` override flattens both arms back to one | ||
| severity, same as any other rule. | ||
| - `seo/hreflang`: wording only, severity unchanged (`warning`). The "2+ alternates without | ||
| x-default" message and recommendation no longer imply a defect — Google's guidance frames | ||
| `x-default` as something to "consider," specifically for language-selector or auto-redirecting | ||
| pages, not a requirement for every multilingual site. The malformed-hreflang-code arm is | ||
| unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.