v1.0 cleanup: remove CLI alias flags, merge PERF rule directories - #186
Conversation
Both were pure aliases (--reporter=json / --fail-on=warning did the same thing) with no independent behavior — removed pre-1.0 with no deprecation period, per the v1.0 cleanup design. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PZVgzgmaCEmTT9mJ5D9SHH
All PERF rules now live in one directory. No behavior change — same rule ids, same allRules contents, same public exports; only the source files' location and two import paths in rules/index.ts changed.
📝 WalkthroughWalkthroughThe CLI removes ChangesCLI alias cleanup
Performance-rule directory merge
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/superpowers/plans/2026-07-12-v1-cleanup-aliases-and-rules-merge.md (1)
155-155: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueAdd language specifiers to fenced code blocks.
Six fenced code blocks lack a language tag (lines 155, 161, 227, 236, 294, 303). While this is an internal planning document, adding
bashortextto each fence improves rendering and silences markdownlint warnings.🔧 Example fix for line 155
-``` +```text</details> Also applies to: 161-161, 227-227, 236-236, 294-294, 303-303 <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.In
@docs/superpowers/plans/2026-07-12-v1-cleanup-aliases-and-rules-merge.mdat
line 155, Add language specifiers to all six untagged fenced code blocks in the
document, using bash for shell commands and text for non-command content. Update
the fences at the referenced locations while preserving their existing contents.</details> <!-- cr-comment:v1:ae5594d99c549064afb60f42 --> _Source: Linters/SAST tools_ </blockquote></details> </blockquote></details> <details> <summary>🤖 Prompt for all review comments with AI agents</summary>Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.Nitpick comments:
In@docs/superpowers/plans/2026-07-12-v1-cleanup-aliases-and-rules-merge.md:
- Line 155: Add language specifiers to all six untagged fenced code blocks in
the document, using bash for shell commands and text for non-command content.
Update the fences at the referenced locations while preserving their existing
contents.</details> --- <details> <summary>ℹ️ Review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: Organization UI **Review profile**: CHILL **Plan**: Pro **Run ID**: `db2693fe-13c2-4026-8c69-d9661e62c81a` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 6c49d946174874aecaa86f7590dad98f9ca65902 and 75c9019a11df32d0079a7a5e0706d9052f55d936. </details> <details> <summary>📒 Files selected for processing (14)</summary> * `.changeset/remove-cli-aliases.md` * `AGENTS.md` * `docs/src/content/docs/guides/cli.md` * `docs/src/content/docs/guides/reporters.md` * `docs/src/content/docs/ja/guides/cli.md` * `docs/src/content/docs/ja/guides/reporters.md` * `docs/superpowers/plans/2026-07-12-v1-cleanup-aliases-and-rules-merge.md` * `docs/superpowers/specs/2026-07-12-v1-cleanup-aliases-and-rules-merge-design.md` * `packages/cli/src/bin.ts` * `packages/cli/src/resolve-args.ts` * `packages/cli/test/resolve-args.test.ts` * `packages/core/src/rules/index.ts` * `packages/core/src/rules/perf/perf009-heavy-import.ts` * `packages/core/src/rules/perf/perf010-namespace-import.ts` </details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Summary
--jsonand--fail-on-warningflags — both were pure aliases for--reporter=json/--fail-on=warning(the help text itself said "Alias for ..."). No deprecation period (pre-1.0, maintainer-approved).packages/core/src/rules/performance/intopackages/core/src/rules/perf/, resolving a splitAGENTS.mdalready documented as a historical wart. Pure file relocation — zero behavior change, confirmed by an identical core test pass count (397/397) before and after the move.Design spec:
docs/superpowers/specs/2026-07-12-v1-cleanup-aliases-and-rules-merge-design.mdImplementation plan:
docs/superpowers/plans/2026-07-12-v1-cleanup-aliases-and-rules-merge.mdBuilt via subagent-driven-development: 2 tasks, each with a fresh implementer + task-scoped reviewer (both approved, zero findings), plus a final whole-branch review (opus, verdict: ready to merge, no Critical/Important findings).
Test plan
pnpm build && pnpm typecheck && pnpm test && pnpm lint— all greenpnpm --filter docs build— 121 pages, no errors--json/--fail-on-warning/rules/performancereferences — clean (only historical CHANGELOG/legacyplans/archives remain, as intended)🤖 Generated with Claude Code
https://claude.ai/code/session_01PZVgzgmaCEmTT9mJ5D9SHH
Summary by CodeRabbit
Breaking Changes
--jsonand--fail-on-warningCLI aliases.--reporter=jsonand--fail-on=warninginstead.CLI Improvements
--fail-on <severity>help text.--scorewith--reportersuppresses reporter output and warns on stderr without changing exit-code behavior.Documentation
Performance Rules