Skip to content

v1.0 cleanup: remove CLI alias flags, merge PERF rule directories - #186

Merged
oekazuma merged 5 commits into
mainfrom
chore/v1-cleanup
Jul 12, 2026
Merged

oekazuma merged 5 commits into
mainfrom
chore/v1-cleanup

Conversation

@oekazuma

@oekazuma oekazuma commented Jul 12, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Removes the CLI's --json and --fail-on-warning flags — both were pure aliases for --reporter=json / --fail-on=warning (the help text itself said "Alias for ..."). No deprecation period (pre-1.0, maintainer-approved).
  • Merges packages/core/src/rules/performance/ into packages/core/src/rules/perf/, resolving a split AGENTS.md already documented as a historical wart. Pure file relocation — zero behavior change, confirmed by an identical core test pass count (397/397) before and after the move.

Design spec: docs/superpowers/specs/2026-07-12-v1-cleanup-aliases-and-rules-merge-design.md
Implementation plan: docs/superpowers/plans/2026-07-12-v1-cleanup-aliases-and-rules-merge.md

Built via subagent-driven-development: 2 tasks, each with a fresh implementer + task-scoped reviewer (both approved, zero findings), plus a final whole-branch review (opus, verdict: ready to merge, no Critical/Important findings).

Test plan

  • pnpm build && pnpm typecheck && pnpm test && pnpm lint — all green
  • pnpm --filter docs build — 121 pages, no errors
  • Core test suite pass count identical before/after the rules-directory move (397/397, 40 files)
  • Grep sweep for stray --json/--fail-on-warning/rules/performance references — clean (only historical CHANGELOG/legacy plans/ archives remain, as intended)

🤖 Generated with Claude Code

https://claude.ai/code/session_01PZVgzgmaCEmTT9mJ5D9SHH

Summary by CodeRabbit

  • Breaking Changes

    • Removed the --json and --fail-on-warning CLI aliases.
    • Use --reporter=json and --fail-on=warning instead.
  • CLI Improvements

    • Added clearer --fail-on <severity> help text.
    • Clarified that combining --score with --reporter suppresses reporter output and warns on stderr without changing exit-code behavior.
  • Documentation

    • Updated English and Japanese CLI and reporter guides with the new syntax and behavior.
  • Performance Rules

    • Consolidated performance rule organization without changing rule behavior.

oekazuma and others added 5 commits July 12, 2026 14:01
Both were pure aliases (--reporter=json / --fail-on=warning did the same
thing) with no independent behavior — removed pre-1.0 with no deprecation
period, per the v1.0 cleanup design.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PZVgzgmaCEmTT9mJ5D9SHH
All PERF rules now live in one directory. No behavior change — same rule
ids, same allRules contents, same public exports; only the source files'
location and two import paths in rules/index.ts changed.
@coderabbitai

coderabbitai Bot commented Jul 12, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The CLI removes --json and --fail-on-warning, updates canonical flag handling and documentation, and adds a changeset. Performance rules PERF009/PERF010 are consolidated under rules/perf, with updated imports and contributor guidance.

Changes

CLI alias cleanup

Layer / File(s) Summary
CLI argument parsing and resolution
packages/cli/src/bin.ts, packages/cli/src/resolve-args.ts
Help text, boolean parsing, reporter resolution, and failure-threshold handling now use only canonical options.
CLI argument validation tests
packages/cli/test/resolve-args.test.ts
Tests use --reporter json and remove coverage for --fail-on-warning.
CLI documentation and cleanup plan
.changeset/*, docs/src/content/docs/guides/*, docs/src/content/docs/ja/guides/*, docs/superpowers/{plans,specs}/*
English/Japanese documentation and planning artifacts describe the canonical flags and alias removal.

Performance-rule directory merge

Layer / File(s) Summary
Performance rule modules and index wiring
packages/core/src/rules/index.ts, packages/core/src/rules/perf/*
PERF009 and PERF010 are defined under rules/perf, and the rule index imports them from that directory.
Performance-rule contributor guidance
AGENTS.md
The historical split-directory note for performance rules is removed.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the two main changes: removing CLI alias flags and merging PERF rule directories.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
docs/superpowers/plans/2026-07-12-v1-cleanup-aliases-and-rules-merge.md (1)

155-155: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Add language specifiers to fenced code blocks.

Six fenced code blocks lack a language tag (lines 155, 161, 227, 236, 294, 303). While this is an internal planning document, adding bash or text to each fence improves rendering and silences markdownlint warnings.

🔧 Example fix for line 155
-```
+```text
</details>


Also applies to: 161-161, 227-227, 236-236, 294-294, 303-303

<details>
<summary>🤖 Prompt for AI Agents</summary>

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @docs/superpowers/plans/2026-07-12-v1-cleanup-aliases-and-rules-merge.md at
line 155, Add language specifiers to all six untagged fenced code blocks in the
document, using bash for shell commands and text for non-command content. Update
the fences at the referenced locations while preserving their existing contents.


</details>

<!-- cr-comment:v1:ae5594d99c549064afb60f42 -->

_Source: Linters/SAST tools_

</blockquote></details>

</blockquote></details>

<details>
<summary>🤖 Prompt for all review comments with AI agents</summary>

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @docs/superpowers/plans/2026-07-12-v1-cleanup-aliases-and-rules-merge.md:

  • Line 155: Add language specifiers to all six untagged fenced code blocks in
    the document, using bash for shell commands and text for non-command content.
    Update the fences at the referenced locations while preserving their existing
    contents.

</details>

---

<details>
<summary>ℹ️ Review info</summary>

<details>
<summary>⚙️ Run configuration</summary>

**Configuration used**: Organization UI

**Review profile**: CHILL

**Plan**: Pro

**Run ID**: `db2693fe-13c2-4026-8c69-d9661e62c81a`

</details>

<details>
<summary>📥 Commits</summary>

Reviewing files that changed from the base of the PR and between 6c49d946174874aecaa86f7590dad98f9ca65902 and 75c9019a11df32d0079a7a5e0706d9052f55d936.

</details>

<details>
<summary>📒 Files selected for processing (14)</summary>

* `.changeset/remove-cli-aliases.md`
* `AGENTS.md`
* `docs/src/content/docs/guides/cli.md`
* `docs/src/content/docs/guides/reporters.md`
* `docs/src/content/docs/ja/guides/cli.md`
* `docs/src/content/docs/ja/guides/reporters.md`
* `docs/superpowers/plans/2026-07-12-v1-cleanup-aliases-and-rules-merge.md`
* `docs/superpowers/specs/2026-07-12-v1-cleanup-aliases-and-rules-merge-design.md`
* `packages/cli/src/bin.ts`
* `packages/cli/src/resolve-args.ts`
* `packages/cli/test/resolve-args.test.ts`
* `packages/core/src/rules/index.ts`
* `packages/core/src/rules/perf/perf009-heavy-import.ts`
* `packages/core/src/rules/perf/perf010-namespace-import.ts`

</details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->

@oekazuma
oekazuma merged commit fcd7f59 into main Jul 12, 2026
7 checks passed
@oekazuma
oekazuma deleted the chore/v1-cleanup branch July 12, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant