[FIX] SidePanel: reset initial props on model change #7478
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
Collaborator
Author
|
This PR targets saas-18.3 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Collaborator
Author
|
@rrahir @VincentSchippefilt ci/runbot failed on this forward-port PR |
Currently, we store the initial props which the sidepanel was open with. This specifically occurs for charts sidepanel where we want the state to update when we select another chart BUT we also want it to stay open when clicking the grid (hence - no active chart left). However the moment we click on another chart than the first one, then it is supposed to become the new "default" chart. How to reproduce: - open the sidepanel of the first chart - select the second chart - delete the second chart => the sidepanel is still open and falls back on the first chart instead of closing. Task: 5059484 X-original-commit: f76210a
rrahir
force-pushed
the
saas-18.3-18.0-close-side-panel-on-dup-chart-rar-478056-fw
branch
from
29e6449 to
1220032
Compare
Collaborator
Author
|
@rrahir @VincentSchippefilt this PR has become a normal PR because head updated from 29e6449 to 1220032. It must be merged be forward-ported further. |
14 tasks
Collaborator
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Nov 18, 2025
Currently, we store the initial props which the sidepanel was open with. This specifically occurs for charts sidepanel where we want the state to update when we select another chart BUT we also want it to stay open when clicking the grid (hence - no active chart left). However the moment we click on another chart than the first one, then it is supposed to become the new "default" chart. How to reproduce: - open the sidepanel of the first chart - select the second chart - delete the second chart => the sidepanel is still open and falls back on the first chart instead of closing. closes #7478 Task: 5059484 X-original-commit: f76210a Signed-off-by: Vincent Schippefilt (vsc) <[email protected]> Signed-off-by: Rémi Rahir (rar) <[email protected]>
14 tasks
fw-bot
deleted the
saas-18.3-18.0-close-side-panel-on-dup-chart-rar-478056-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we store the initial props with which the sidepanel was open. This specifically occurs for charts sidepanel where we want the stat to update when we select another chart BUT we also want it to stay open when clicking the grid (hence - no active chart left).
However the moment we click on another chart than the first one, then it is supposed to become the new "default" chart.
How to reproduce:
=> the sidepanel is still open and falls back on the first chart instead of closing.
Task: 5059484
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist
Forward-Port-Of: #7184