Skip to content

Conversation

@fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Nov 14, 2025

Description:

Before this commit:

  • splitReference removed single quotes from sheet names.

After this commit:

  • Applied getCanonicalSymbolName after splitReference to ensure sheet
    Names with spaces keep their quotes.

Task: 5244798

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #7409

@robodoo
Copy link
Collaborator

robodoo commented Nov 14, 2025

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Nov 14, 2025

@rmbh-odoo @LucasLefevre cherrypicking of pull request #7409 failed.

stdout:

Auto-merging src/helpers/reference_type.ts
CONFLICT (content): Merge conflict in src/helpers/reference_type.ts
Auto-merging tests/composer/standalone_composer_component.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Before this commit:
- 'splitReference' removed single quotes from sheet names.

After this commit:
- Applied 'getCanonicalSymbolName' after 'splitReference' to ensure sheet
  Names with spaces keep their quotes.

Task: 5244798
X-original-commit: 2a23ddd
@rmbh-odoo rmbh-odoo force-pushed the master-saas-18.4-fix-reference-type-single-quote-sheet-rmbh-477250-fw branch from 047a0b3 to 9a426db Compare November 14, 2025 13:43
@rmbh-odoo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Nov 15, 2025
Before this commit:
- 'splitReference' removed single quotes from sheet names.

After this commit:
- Applied 'getCanonicalSymbolName' after 'splitReference' to ensure sheet
  Names with spaces keep their quotes.

closes #7465

Task: 5244798
X-original-commit: 2a23ddd
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Signed-off-by: Ronakkumar Mukeshbhai Bharadiya (rmbh) <[email protected]>
@robodoo robodoo closed this Nov 15, 2025
@robodoo robodoo added the 19.1 label Nov 15, 2025
@fw-bot fw-bot deleted the master-saas-18.4-fix-reference-type-single-quote-sheet-rmbh-477250-fw branch November 22, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants