[IMP] pivots: implement pivot table styles #7455
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
hokolomopo
changed the title
hokolomopo
force-pushed
the
master-pivot-table-style-adrm
branch
4 times, most recently
from
e30e965 to
cd9fa6d
Compare
| fillColor?: Color; | ||
| textColor?: Color; | ||
| fontSize?: number; // in pt, not in px! | ||
| skipCellGridLines?: boolean; |
Collaborator
There was a problem hiding this comment.
I'm really not a fan of adding this to Style which is supposed to be the core, raw data for style, while skipCellGridLines seems to be something derived from other things
EDIT: mouais...I see
packages/o-spreadsheet-engine/src/helpers/pivot_table_presets.ts
Outdated
Show resolved
Hide resolved
packages/o-spreadsheet-engine/src/plugins/ui_core_views/pivot_ui.ts
Outdated
Show resolved
Hide resolved
| templateName: "pivotMediumBlackHeaders", | ||
| primaryColor: colorSet.highlight, | ||
| wholeTable: { | ||
| style: { skipCellGridLines: true, fillColor: colorSet.light }, |
Collaborator
There was a problem hiding this comment.
skipCellGridLines: true not useful if there's a fill color ?
Contributor
Author
There was a problem hiding this comment.
But drawing grid lines just to paint a color over it is also useless 🤷
Collaborator
|
And the feature is really cool 👍 |
This commit extracts the logic that tracks the occurrence of the SUBTOTAL formulas to a more generic plugin named `formula_tracker`. This will be used to track the occurrences of `PIVOT` formulas in a future commit. Task: 4552232
Before this commit, the table style presets contained all the style of a table, except the `bold` property, which was handled separately and applied to every total/header row or first/last column. This made the code harder to read with two sources of truth for the style, and with the introduction of pivot table styles, every header row won't be in bold anymore. This commit adds the `bold` property to the table style presets, os it is handled like every other style property. Task: 4552232
hokolomopo
force-pushed
the
master-pivot-table-style-adrm
branch
2 times, most recently
from
cb9ce4a to
ed35656
Compare
This commit introducing cell animations added an option `skipCellGridLines` to the rendering boxes. The option allows to skip drawing grid lines for specific cells. This commit changes this rendering box option into a standard cell style option, so it can be used in other parts of the codebase as well. Task: 4552232
With this commit, the cell background are now drawn totally covering the grid lines. It's way prettier for table/pivots to have an uniform background color without grid lines breaking it. The downside is we cannot draw the hover overlay with a color alpha, because it would overlap with the next cell, making a darker color at the border. We can workaround by merging the colors programmatically and avoid drawing with alpha. Task: 4552232
With this commit, we don't need to manually create a dynamic table to a pivot to have a style applied. Instead we can add a style in the pivot definition, and dynamic tables will automatically be created on the dynamic pivot formulas. Those new pivot styles are better than traditional tables styles because: - they are directly linked to the pivot, taking into account the number of headers, the presence of totals, etc. - they are automatically added on `=PIVOT()` formulas, without the need to create a dynamic table first. - they are more powerful than the old table styles, they can have a style for the sub-headers, the measure headers, etc. Task: 4552232
hokolomopo
force-pushed
the
master-pivot-table-style-adrm
branch
from
ed35656 to
63cb270
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
[IMP] pivots: implement pivot table styles
With this commit, we don't need to manually create a dynamic table
to a pivot to have a style applied. Instead we can add a style in the
pivot definition, and dynamic tables will automatically be created on
the dynamic pivot formulas.
Those new pivot styles are better than traditional tables styles because:
number of headers, the presence of totals, etc.
=PIVOT()formulas, without the need tocreate a dynamic table first.
style for the sub-headers, the measure headers, etc.
[IMP] renderer: draw cell background over grid lines
With this commit, the cell background are now drawn totally covering
the grid lines. It's way prettier for table/pivots to have an uniform
background color without grid lines breaking it.
The downside is we cannot draw the hover overlay with a color alpha,
because it would overlap with the next cell, making a darker color
at the border. We can workaround by merging the colors programmatically
and avoid drawing with alpha.
[IMP] style: add
skipCellGridLinesstyle optionThis commit introducing cell animations added an option
skipCellGridLinesto the rendering boxes. The option allows toskip drawing grid lines for specific cells.
This commit changes this rendering box option into a standard cell
style option, so it can be used in other parts of the codebase as well.
[REF] table style: add
boldto table style presetsBefore this commit, the table style presets contained all the style of
a table, except the
boldproperty, which was handled separately andapplied to every total/header row or first/last column.
This made the code harder to read with two sources of truth for the
style, and with the introduction of pivot table styles, every header
row won't be in bold anymore.
This commit adds the
boldproperty to the table style presets,os it is handled like every other style property.
Task: 4552232
review checklist