Skip to content

Conversation

@fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Nov 7, 2025

Description

If we have a range with an invalid sheet name, the sheet name is not escaped with quotes when it contains special characters when converting the range back to a string.

Task: 5125762

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #7420
Forward-Port-Of: #7337

If we have a range with an invalid sheet name, the sheet name is not
escaped with quotes when it contains special characters when converting
the range back to a string.

Task: 5125762
X-original-commit: 12b77d0
@robodoo
Copy link
Collaborator

robodoo commented Nov 7, 2025

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Nov 7, 2025

@hokolomopo @LucasLefevre cherrypicking of pull request #7337 failed.

stdout:

Auto-merging src/helpers/range.ts
Auto-merging tests/model/model_import_export.test.ts
CONFLICT (content): Merge conflict in tests/model/model_import_export.test.ts
Auto-merging tests/range_plugin.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants