[FIX] range: invalid sheet name with special character #7416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
Collaborator
Author
|
This PR targets 18.0 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Collaborator
Author
|
@hokolomopo @LucasLefevre ci/runbot failed on this forward-port PR |
If we have a range with an invalid sheet name, the sheet name is not escaped with quotes when it contains special characters when converting the range back to a string. Task: 5125762 X-original-commit: d9d0f31
hokolomopo
force-pushed
the
18.0-17.0-fix-invalid-sheet-name-adrm-470619-fw
branch
from
fcd7930 to
5df0f06
Compare
Collaborator
Author
|
@hokolomopo @LucasLefevre this PR has become a normal PR because head updated from fcd7930 to 5df0f06. It must be merged be forward-ported further. |
Contributor
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Nov 7, 2025
If we have a range with an invalid sheet name, the sheet name is not escaped with quotes when it contains special characters when converting the range back to a string. closes #7416 Task: 5125762 X-original-commit: d9d0f31 Signed-off-by: Lucas Lefèvre (lul) <[email protected]> Signed-off-by: Adrien Minne (adrm) <[email protected]>
This was referenced Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we have a range with an invalid sheet name, the sheet name is not escaped with quotes when it contains special characters when converting the range back to a string.
Task: 5125762
review checklist
Forward-Port-Of: #7337