[FIX] composer: fix get/setText of the content editable helper #7393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

The recent use of the property "plaintext-only" came with a change of
behaviour in the composers, specifically in Firefox.
How to reproduce in FF:
-> a new line is inserted
Apparently, when setting the attribute
contentEditabletoplaintext-only, deleting the single character does not delete the spanthat encapsulates it if the latter has a class attribute. This couples
with a recent refactoring of the content editable helper to handle new
line characters and the empty composer is not detected as such
What happens currently?
Consider the composer content after inputing the letter 'W':
The cursor is set just after the letter W.
In a chromium-based browser, hitting the
Deletekey yeilds thefollowing result:
The letter is replaced by
<br>which could be interpreted as anewline, except that in this situation, we do not want a newline to
appear as we meerly deleted the single character of the composer, so
we do not want new characters.
Also, we introduced some logic to fight this side-effect when we
introduced the support of newlines of pasted content (#6467)
However, it turns out that in firefox, hitting
Deletewill yield thisresult
The class attribute is not cleared up! And unfortunately, the logic that
counteracts the presence of the unwelcome
<br>would test against theexact form seen in a chromium-based browser, so it did not work on
Firefox.
This commit extends the check to work on both Firefox-based and
Chromium-based browsers.
Note that other leads were investigated and it seems that if we stopped
using paragraphs to represent new lines, this issue with the
<br>doesn't seem to occur. An improvement (and good cleanup) could be
achieved by dropping that paragraph strategy and rely on spans and br
characters.
Task: 5082601
Task: 5082601
Description:
description of this task, what is implemented and why it is implemented that way.
Task: 5082601
review checklist
Forward-Port-Of: #7331