Skip to content

Conversation

@fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Oct 20, 2025

Description

We have a function forceUnicityOfFigure that repair the spreadsheet data at import to force the figure ID unicity. But since the introduction of carousels, we also need to ensure the chart ID unicity (after the migration, chart ID and figure ID are the same).

Task: 5153264

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #7283

We have a function `forceUnicityOfFigure` that repair the spreadsheet
data at import to force the figure ID unicity. But since the
introduction of carousels, we also need to ensure the chart ID unicity
(after the migration, chart ID and figure ID are the same).

Task: 5153264
X-original-commit: cb66cfd
@robodoo
Copy link
Collaborator

robodoo commented Oct 20, 2025

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Oct 20, 2025

@hokolomopo @pro-odoo this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@pro-odoo
Copy link
Collaborator

robodoo r+

robodoo pushed a commit that referenced this pull request Oct 20, 2025
We have a function `forceUnicityOfFigure` that repair the spreadsheet
data at import to force the figure ID unicity. But since the
introduction of carousels, we also need to ensure the chart ID unicity
(after the migration, chart ID and figure ID are the same).

closes #7356

Task: 5153264
X-original-commit: cb66cfd
Signed-off-by: Pierre Rousseau (pro) <[email protected]>
@robodoo robodoo added the 19.1 label Oct 20, 2025
@robodoo robodoo closed this Oct 20, 2025
@fw-bot fw-bot deleted the master-19.0-fix-duplicate-chart-id-adrm-468803-fw branch October 27, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants