Skip to content

[FW][FIX] xlsx: correctly export aggregated charts#6238

Closed
fw-bot wants to merge 1 commit intosaas-18.1from
saas-18.1-17.0-aggregated-chart-xlsx-export-adrm-432590-fw
Closed

[FW][FIX] xlsx: correctly export aggregated charts#6238
fw-bot wants to merge 1 commit intosaas-18.1from
saas-18.1-17.0-aggregated-chart-xlsx-export-adrm-432590-fw

Conversation

@fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Apr 29, 2025

Description

The feature to aggregate the chart data based on the labels does not exist in xlsx files. But rather than exporting the chart as normal, ignoring the aggregation, we exported the chart as an image.

Task: 4714410

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #6234
Forward-Port-Of: #6075

@robodoo
Copy link
Collaborator

robodoo commented Apr 29, 2025

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Apr 29, 2025

@hokolomopo @rrahir cherrypicking of pull request #6075 failed.

stdout:

Auto-merging src/helpers/figures/charts/bar_chart.ts
Auto-merging src/helpers/figures/charts/line_chart.ts
Auto-merging src/helpers/figures/charts/pie_chart.ts
Auto-merging tests/xlsx/xlsx_export.test.ts
CONFLICT (content): Merge conflict in tests/xlsx/xlsx_export.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

The feature to aggregate the chart data based on the labels does not
exist in xlsx files. But rather than exporting the chart as normal,
ignoring the aggregation, we exported the chart as an image.

Task: 4714410
X-original-commit: 918b3cc
@hokolomopo hokolomopo force-pushed the saas-18.1-17.0-aggregated-chart-xlsx-export-adrm-432590-fw branch from 75357f9 to 1159259 Compare April 29, 2025 09:21
@hokolomopo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Apr 29, 2025
The feature to aggregate the chart data based on the labels does not
exist in xlsx files. But rather than exporting the chart as normal,
ignoring the aggregation, we exported the chart as an image.

closes #6238

Task: 4714410
X-original-commit: 918b3cc
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
@robodoo robodoo closed this Apr 29, 2025
@fw-bot fw-bot deleted the saas-18.1-17.0-aggregated-chart-xlsx-export-adrm-432590-fw branch May 6, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants