[FW][FIX] viewport: remove snap-friendly margins #6130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
Collaborator
Author
|
@rrahir @pro-odoo cherrypicking of pull request #5988 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Since the introduction of the smooth viewports, the "comfort" margins at the end of the main viewport are no longer necessary. They were introduced to ensure that the viewport could be snapped properly. Task: 4633503
The scrollbar size was not fully aligned with the grid in Firefox. This could cause minor inconvenience when scrolling while drag n droping the scrollbar with the mouse. However the error would be of merely 15 pixel and clicking on any on the cell of the last header would correct the issue. Task: 4633503
rrahir
force-pushed
the
master-saas-18.2-remove-margins-viewport-rar-424469-fw
branch
from
f48d9c3 to
44b0ac1
Compare
Collaborator
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 18, 2025
Since the introduction of the smooth viewports, the "comfort" margins at the end of the main viewport are no longer necessary. They were introduced to ensure that the viewport could be snapped properly. Task: 4633503 Part-of: #6130 Signed-off-by: Pierre Rousseau (pro) <[email protected]> Signed-off-by: Rémi Rahir (rar) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Apr 18, 2025
The scrollbar size was not fully aligned with the grid in Firefox. This could cause minor inconvenience when scrolling while drag n droping the scrollbar with the mouse. However the error would be of merely 15 pixel and clicking on any on the cell of the last header would correct the issue. closes #6130 Task: 4633503 Signed-off-by: Pierre Rousseau (pro) <[email protected]> Signed-off-by: Rémi Rahir (rar) <[email protected]>
fw-bot
deleted the
master-saas-18.2-remove-margins-viewport-rar-424469-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: 4633503
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist
Forward-Port-Of: #5988