Standalone composer fixes #6127
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit backports the `toHaveClass` and `toHaveAttribute` matchers. Task: 4724069
The content of the standalone composer was not localized. Task: 4724069
This commit adds an `invalid` indicator in the standalone composer of the calculated measure if the formula is invalid. Note that it's only in error if the compilation is invalid, we cannot evaluate there as it will be different for each row/col of the pivot. Task: 4724069
Collaborator
|
|
rrahir
reviewed
May 12, 2025
| composerContent="measure.computedBy.formula" | ||
| defaultRangeSheetId="measure.computedBy.sheetId" | ||
| contextualAutocomplete="getMeasureAutocomplete()" | ||
| invalid="isCalculatedMeasureInvalid" |
Collaborator
There was a problem hiding this comment.
I'll let francois decide but it feels like the simple "o-invalid" doesn't draw enough attention
LucasLefevre
approved these changes
May 16, 2025
Collaborator
LucasLefevre
left a comment
LucasLefevre
left a comment
There was a problem hiding this comment.
robodoo r+ rebase-ff
Collaborator
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
May 16, 2025
This commit backports the `toHaveClass` and `toHaveAttribute` matchers. Task: 4724069 Part-of: #6127 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
May 16, 2025
The content of the standalone composer was not localized. Task: 4724069 Part-of: #6127 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
This was referenced May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] pivot: add
invalidindicator for wrong calculated measureThis commit adds an
invalidindicator in the standalone composer ofthe calculated measure if the formula is invalid.
Note that it's only in error if the compilation is invalid, we cannot
evaluate there as it will be different for each row/col of the pivot.
[FIX] standalone composer: localize content
The content of the standalone composer was not localized.
[IMP] tests: add additional jest matchers
This commit backports the
toHaveClassandtoHaveAttributematchers.Task: 4724069
review checklist