Skip to content

[IMP] chart: detect hierarchical chart at chart creation #6092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hokolomopo wants to merge 1 commit into from
Closed

[IMP] chart: detect hierarchical chart at chart creation #6092

hokolomopo wants to merge 1 commit into from

Conversation

@hokolomopo
Copy link
Contributor

@hokolomopo hokolomopo commented Apr 14, 2025

Description

With this commit, at the chart creation we will check if the data in the selected zone looks like a hierarchical dataset (multiple columns with string values, and one column with numeric values). If so, we will create a sunburst chart instead of a car chart.

Task: 4724420

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@hokolomopo
[IMP] chart: detect hierarchical chart at chart creation
25f119c 
With this commit, at the chart creation we will check if the data in
the selected zone looks like a hierarchical dataset (multiple
columns with string values, and one column with numeric values).
If so, we will create a sunburst chart instead of a car chart.

Task: 4724420
@robodoo
Copy link
Collaborator

robodoo commented Apr 14, 2025

Pull request status dashboard

pro-odoo
pro-odoo approved these changes Apr 17, 2025
View reviewed changes
Copy link
Collaborator

@pro-odoo pro-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Apr 17, 2025
@hokolomopo
[IMP] chart: detect hierarchical chart at chart creation
bc4308a 
With this commit, at the chart creation we will check if the data in
the selected zone looks like a hierarchical dataset (multiple
columns with string values, and one column with numeric values).
If so, we will create a sunburst chart instead of a car chart.

closes #6092

Task: 4724420
Signed-off-by: Pierre Rousseau (pro) <[email protected]>
@robodoo robodoo added the 18.3 label Apr 17, 2025
@robodoo robodoo closed this Apr 17, 2025
@fw-bot fw-bot deleted the master-smart-hierarchical-chart-adrm branch April 24, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pro-odoo pro-odoo pro-odoo approved these changes

Assignees

No one assigned

Labels

18.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hokolomopo @robodoo @pro-odoo