Skip to content

[IMP] xlsx: support import/export of doughnut, pyramid & horizontal bar charts#5448

Closed
Rachico wants to merge 1 commit intomasterfrom
master-xlsx-charts-mera
Closed

[IMP] xlsx: support import/export of doughnut, pyramid & horizontal bar charts#5448
Rachico wants to merge 1 commit intomasterfrom
master-xlsx-charts-mera

Conversation

@Rachico
Copy link
Contributor

@Rachico Rachico commented Jan 9, 2025

This commit adds support for exporting & importing doughnut, pyramid & horizontal bar charts. Pyramid charts are not supported in Excel, therefore, we do a best effort by exporting them as horizontal bar charts.

Task: 3978237

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Jan 9, 2025

Pull request status dashboard

@Rachico Rachico force-pushed the master-xlsx-charts-mera branch 6 times, most recently from f4c84b0 to 087e6ac Compare January 13, 2025 09:53
Copy link
Contributor

@hokolomopo hokolomopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scrolled really fast. I think you forgot Lucas' review

@Rachico Rachico force-pushed the master-xlsx-charts-mera branch 16 times, most recently from 4a2a480 to 8568698 Compare April 7, 2025 14:58
@Rachico Rachico force-pushed the master-xlsx-charts-mera branch 4 times, most recently from c041959 to 133da0e Compare April 14, 2025 14:11
@Rachico Rachico force-pushed the master-xlsx-charts-mera branch 10 times, most recently from 3ee839c to 2081d80 Compare June 16, 2025 15:24
@Rachico Rachico force-pushed the master-xlsx-charts-mera branch 9 times, most recently from a70826d to a460070 Compare July 2, 2025 12:03
@Rachico Rachico force-pushed the master-xlsx-charts-mera branch 2 times, most recently from 94402de to 2561685 Compare July 4, 2025 14:58
@Rachico Rachico force-pushed the master-xlsx-charts-mera branch from 2561685 to a6421fc Compare July 17, 2025 13:31
…ar charts

This commit adds support for exporting & importing doughnut, pyramid & horizontal
bar charts. Pyramid charts are not supported in Excel, therefore, we do a best effort
by exporting them as two grouped horizontal bar charts with a common vertical and
horizontal axes.

Task: 3978237
@hokolomopo hokolomopo force-pushed the master-xlsx-charts-mera branch from a6421fc to 0801f85 Compare July 18, 2025 11:42
Copy link
Contributor

@hokolomopo hokolomopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo r+

pushed the fix. PR seems good, a lot of changes to different places but splitting into different commits sounds too annoying at this point

robodoo pushed a commit that referenced this pull request Jul 18, 2025
…ar charts

This commit adds support for exporting & importing doughnut, pyramid & horizontal
bar charts. Pyramid charts are not supported in Excel, therefore, we do a best effort
by exporting them as two grouped horizontal bar charts with a common vertical and
horizontal axes.

closes #5448

Task: 3978237
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
@robodoo robodoo added the 18.5 label Jul 18, 2025
@robodoo robodoo closed this Jul 18, 2025
@fw-bot fw-bot deleted the master-xlsx-charts-mera branch July 25, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants