Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] delay popup #4245

Draft
wants to merge 3 commits into
base: master-mysterious-egg
Choose a base branch
from

Conversation

loco-odoo
Copy link

No description provided.

@robodoo
Copy link

robodoo commented Mar 25, 2025

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged.

@loco-odoo
Copy link
Author

loco-odoo commented Mar 25, 2025

The problem of the first commit is that the units are saved in the data attribute. There is no problem in stable as selectDataAttribute removes the unit if needed. This can not be implemented in stable as this would have to be implemented at the shorthand action level that does not have access to the saveUnit info (see getActionsSpecs -> getAllActions -> getShorthandActions).
As the concept of a saveUnit is not that much used in the context of a data-attribute, I decided to go for a custom action.

@loco-odoo loco-odoo force-pushed the master-mysterious-egg-loco-3 branch 2 times, most recently from a40332c to dc882ae Compare March 27, 2025 09:27
@FrancoisGe FrancoisGe force-pushed the master-mysterious-egg branch from f468b7f to 80b3d5d Compare March 27, 2025 12:21
@loco-odoo loco-odoo force-pushed the master-mysterious-egg-loco-3 branch 2 times, most recently from 7612f67 to 44cc095 Compare March 27, 2025 13:31
@ged-odoo ged-odoo force-pushed the master-mysterious-egg branch from 27a1402 to 8c6b756 Compare March 27, 2025 20:00
@loco-odoo loco-odoo force-pushed the master-mysterious-egg-loco-3 branch 5 times, most recently from aa1f568 to 0742e0b Compare April 1, 2025 09:37
@loco-odoo loco-odoo force-pushed the master-mysterious-egg-loco-3 branch 2 times, most recently from 0a378bb to ad82889 Compare April 1, 2025 13:38
@loco-odoo loco-odoo force-pushed the master-mysterious-egg-loco-3 branch from ad82889 to 24cb90c Compare April 1, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants