InstagramPage (.s_instagram_page) #4209
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
FrancoisGe
force-pushed
the
master-mysterious-egg
branch
from
3ee87bf to
98b990a
Compare
blse-odoo
force-pushed
the
master-mysterious-egg-4-blse
branch
3 times, most recently
from
dce7d9e to
01a2181
Compare
| clean_for_save_handlers: ({ root }) => { | ||
| for (const el of root.querySelectorAll(".s_instagram_page iframe")) { | ||
| el.remove(); | ||
| } | ||
| }, |
There was a problem hiding this comment.
Why we need to remove it ? Who is adding this node
There was a problem hiding this comment.
It's added by the interaction. I don't know why it is not clean up before the save. But if I don't clean it here, there are two iframes after the save
addons/html_builder/static/src/plugins/instagram_option_plugin.js
Outdated
Show resolved
Hide resolved
addons/html_builder/static/src/plugins/instagram_option_plugin.js
Outdated
Show resolved
Hide resolved
| Your instagram page must be public to be integrated into an Odoo website. | ||
| </div> | ||
| <BuilderRow label.translate="Instagram Page"> | ||
| <BuilderTextInput dataAttributeAction="'instagramPage'" action="'instagramPageAction'"/> |
There was a problem hiding this comment.
why not do every thing in instagramPageAction ? I m not sure it s a good idea to use dataAttributeAction in this case. If the apply order change it will be broken. Could you add 1 or 2 tests ?
There was a problem hiding this comment.
Indeed that is a good idea to put it all in instagramPageAction, I'll do that
There was a problem hiding this comment.
(so I did not add tests for this)
addons/html_builder/static/src/plugins/instagram_option_plugin.js
Outdated
Show resolved
Hide resolved
blse-odoo
force-pushed
the
master-mysterious-egg-4-blse
branch
5 times, most recently
from
f2221f6 to
a98f0d7
Compare
addons/html_builder/static/src/plugins/facebook_option_plugin.js
Outdated
Show resolved
Hide resolved
blse-odoo
force-pushed
the
master-mysterious-egg-4-blse
branch
from
a98f0d7 to
7b1d402
Compare
blse-odoo
force-pushed
the
master-mysterious-egg-4-blse
branch
from
7b1d402 to
0005c9f
Compare
No description provided.