ImageSnippet (.s_image) #4207
Open
ImageSnippet (.s_image) #4207
+42,796
−242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
Rewrite `AddElementOption` and `SpacingOption` to be compatible with masonry snipet Implement `AddElementOption` button functionalities
This uses a custom history mutation system, because modification of wrapwrap node are outside of the editable scope and not detected. This uses a custom save system, like the old option. TopMenuVisibility is the only header option modifying the current page header and not every header. It is not usable on every page (like a product page), doing so by checking the input node header_visible to know if the header is customisable.
The values added in the snippet comes from `addons/website/static/src/snippets/s_facebook_page/options.js` > `facebookPage` > `willStart` Special handling to set the link based on data from the orm, has been made with the help of nby (I'm not that confident to leave such a warning by myself :p )
With this commit, the user can now change the columns in image galleries. The columns can be changed in the grid and the masonry layout.
FrancoisGe
force-pushed
the
master-mysterious-egg
branch
from
3ee87bf to
98b990a
Compare
I added a resource `before_add_element_handlers` that allows to add asynchronous steps to transform an element before it is added to the document And use it to ask the user what image to add
blse-odoo
force-pushed
the
master-mysterious-egg-2-blse
branch
from
9461045 to
a30c5e0
Compare
FrancoisGe
force-pushed
the
master-mysterious-egg
branch
from
f468b7f to
80b3d5d
Compare
ged-odoo
force-pushed
the
master-mysterious-egg
branch
from
27a1402 to
8c6b756
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a resource
before_add_element_handlersthat allows to add asynchronous steps to transform an element before it is added to the documentAnd use it to ask the user what image to add