ODK-X Instance row control buttons.

[juayuohcarineneng19]

ODK-X Instance row control buttons adjusted to fit on one row (edit and delete icons).

ODK-X Survey: Update the buttons, icons and list view of the home screen

[maprehensive]

Hi @juayuohcarineneng19 , nice work.

One suggestion I have is to add some padding between these two buttons to reduce the likelihood of tapping the wrong button.

This layout looks better visually, but you could address the potential usability problem as well.

[juayuohcarineneng19]

Okay . working on it now. Thank you

…

On Tue, 9 Jul 2024 at 15:28, Ben Green ***@***.***> wrote: ***@***.**** commented on this pull request. Hi @juayuohcarineneng19 <https://github.com/juayuohcarineneng19> , nice work. One suggestion I have is to add some padding between these two buttons to reduce the likelihood of tapping the wrong button. This layout looks better visually, but you could address the potential usability problem as well. — Reply to this email directly, view it on GitHub <#211 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYBPQRMPLN5K7OMJUPYAWVLZLPQPJAVCNFSM6AAAAABKQX4FE6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNRWGMZDQMJYGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[juayuohcarineneng19]

Added a gap of 5px.

[nuilewis]

Permit me to nitpick please😅
If it's possible to be adjusted, then great... if not then don't waste too much time on it, you can move on to other things.

[Redeem-Grimm-Satoshi]

Great but I haven't seen a change in the icon ( edit, delete ), the icons had to be changed to the material ones. Perhaps, the delete icon doesn't serve it purpose, it should be changed to the trash icon ( you know what I mean )

@nuilewis Great suggestion there, you just asked what I had in mind

[Redeem-Grimm-Satoshi]

@Redeem-Grimm-Satoshi please this pull request is linked to this design. So I was mainly concern about the design.

Here is the issue on updating every icon to material design guideline

I look forward to working on all of these issues. thank you.

@juayuohcarineneng19 Isn't the icons part of the design? I want the icon changes included in this PR

[juayuohcarineneng19]

@Redeem-Grimm-Satoshi please this pull request is linked to this design. So I was mainly concern about the design.
Here is the issue on updating every icon to material design guideline
I look forward to working on all of these issues. thank you.

@juayuohcarineneng19 Isn't the icons part of the design? I want the icon changes included in this PR

Sure @Redeem-Grimm-Satoshi working on it now.

[juayuohcarineneng19]

Permit me to nitpick please😅 If it's possible to be adjusted, then great... if not then don't waste too much time on it, you can move on to other things.

Thank you @nuilewis . Taking these into consideration.

[juayuohcarineneng19]

Permit me to nitpick please😅 If it's possible to be adjusted, then great... if not then don't waste too much time on it, you can move on to other things.

Thank you @nuilewis . Taking these into consideration.

@nuilewis @Redeem-Grimm-Satoshi here is what I have now. I am still learning how to use material design icons once I am done I will move to implemting it.

.

[nuilewis]

Permit me to nitpick please😅 If it's possible to be adjusted, then great... if not then don't waste too much time on it, you can move on to other things.

Thank you @nuilewis . Taking these into consideration.

@nuilewis @Redeem-Grimm-Satoshi here is what I have now. I am still learning how to use material design icons once I am done I will move to implemting it.

.

Much better, good work 👍

[Redeem-Grimm-Satoshi]

Looks fine

@Chinex-Boroja Please check this out for any testing related issues
@r0ssing Please check this out, It's ready to be merged

[juayuohcarineneng19]

@Redeem-Grimm-Satoshi @nuilewis @maprehensive
Please I wish to add modifications made on the icons to this pull request since its not yet merged

[juayuohcarineneng19]

Updated material design icon on image 2

[r0ssing]

Great work! I think these design changes really helps make the application easier to use..
Now that you are working in the 'instances.handlebars' file, is it possible to indent the "Create New Instance" button a little bit so it aligns with the rest of the content? (and maybe remove one of the two horisontal rulers below, so there is only one?)

[r0ssing]

Looks good to me.
Let me know if you get a chance to also indent the "Create new instance" button, then I will re-review it again - otherwise this is fine to merge... 🥇

[r0ssing]

Hello - great work! 👍
One small question regarding the CSS; Is the '!important' tag necessary?
It is really a kind of last resort in CSS (i.e. when something "more specific" exists in the css inheritance hierarchy).. However - if it is indeed needed here, then just ignore this comment! 😄

[r0ssing]

indentation issue...

[Redeem-Grimm-Satoshi]

Great work! I think these design changes really helps make the application easier to use.. Now that you are working in the 'instances.handlebars' file, is it possible to indent the "Create New Instance" button a little bit so it aligns with the rest of the content? (and maybe remove one of the two horisontal rulers below, so there is only one?)

@r0ssing I guess this was addressed in this PR: #208

It will preferable we merge older PR first before the new ones to avoid mix ups

[r0ssing]

@Redeem-Grimm-Satoshi thanks for pointing this out! In that case I agree, that it will be easier if those are merged first (and backmerged into/updated in this PR)

[Redeem-Grimm-Satoshi]

@Redeem-Grimm-Satoshi thanks for pointing this out! In that case I agree, that it will be easier if those are merged first (and backmerged into/updated in this PR)

Yes sure