Add missing imports to core test suite

[Feoramund]

I forgot about this.

[Feoramund]

The core:flags Windows test failed for error code 32.

ERROR_SHARING_VIOLATION

32 (0x20)

The process cannot access the file because it is being used by another process.

It failed on the cleanup part of checking if os.Handle is parsed correctly where it deletes the temporary file. I'm wondering if I should strike that out, since I'm not sure in what way this error is arising, and it's not highly necessary to remove it since it's only a few bytes.

[laytan]

I am pretty sure that error arises there because you have not closed your file handles before trying to delete the file, the defers run after your attempted deletion.

[Feoramund]

Oh, that makes perfect sense. I can just defer the removal too. Why this is allowed on every other platform is beyond me.

[laytan]

Should be

defer {
    if !testing.failed(t) {
        ...
    }
}

right?

Currently it will check if the test failed at the beginning of the test, which is always false.

[Feoramund]

This may be a quirk of the syntax, but I did test this before.

package deferred

import "core:fmt"

main :: proc() {
	a := false
	defer if a {
		fmt.println("Hellope.")
	}
	a = true
}

This prints for me.

[Feoramund]

I made a discussion for this since it seems like something that could be confusing. #3782

[laytan]

Oh strange I could've sworn it was a thing used to defer something IF the condition is currently true.
Because

if true {
    defer blah()
}

Would execute blah at the end of that if block, not at the end of the wanted scope.

I really thought defer if was created to get around that, @gingerBill ?

I guess I got the wrong impression somewhere and it really is just deferring the if statement.

[Feoramund]

I did a quick peek through git log for defer if and all I could find was 118ab60 by @Kelimion.

[Kelimion]

But mainly I wrote it out that way because just by reading left to right we can rephrase the Odin code into English that highlights we want defer if (deferred conditional), not if defer (conditional defer) if we're unsure which of the two we should write.

That there's the confusion to begin with and that the 2nd phrasing is nonsensical in practice suggests it should be made an error.

[Feoramund]

I can't get if defer a { /* ... */ } to compile, if this was meant as a concrete and not a hypothetical syntax example.

[Kelimion]

Confirmed. Well, nothing to worry about then.

[laytan]

I thought we all meant if x do defer ... here

[Kelimion]

Yes, I tried if a defer and it doesn't compile.